Development: Add client sided endpoints parser

[Jan-Thurner]

Checklist

General

• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Pull Requests

Pull Requests related to the requested feature:
#8407
#8455

Context

The Proposed feature extends the GitHub Action originally created in this PR . The original PR focused on parsing information related to changed server endpoints, a crucial step in ensuring the accuracy of server-side interactions within the Artemis codebase. The proposed extension further enhances this functionality by introducing the parsing of client-sided REST calls. Currently, the focus is on extracting essential information such as the HTTP methods and URLs used in these calls. While the current scope is limited to parsing HTTP methods and URLs, this extension lays the groundwork for future enhancements aimed at improving code quality and development efficiency within the Artemis project.

Problem

Errors, like a mismatch in the URLs of REST calls and endpoints, slipping through the code review and testing process could break features and reduce a system's usability. The problem tackled in this issue is that reviewing client-sided REST calls manually is a time-consuming and error-prone task, potentially leading to:

• Delayed Development: Time-consuming tasks can slow down the development process, potentially delaying the delivery of new features or updates.
• Reduced Efficiency: When tasks are error-prone, developers may need to spend additional time fixing mistakes, reducing overall efficiency.
• Increased Costs: Time is money, as they say. Any inefficiencies in the development process can lead to increased costs, whether it's in terms of developer hours or missed deadlines.
• Quality Issues: Errors that slip through the review process can lead to bugs or issues in the software, potentially affecting its stability, performance, or security.
• Negative User Experience: Ultimately, if errors make it into the final product, users may experience disruptions or frustration, leading to a poor user experience and potentially impacting user retention or satisfaction.

Motivation

The motivation behind this feature is to simplify reviewing newly created or modified REST calls. The tedious task of manually parsing out relevant Information regarding a system's REST calls should be automated to increase the efficiency in the reviewing process

---

Requirements Engineering

Proposed System

The proposed solution is a GitHub action analyzing the client-sided REST calls on every commit. It should use the Library TypeScript Compiler API to build an abstract syntax tree (AST) representing the changed typescript files within each PR. The AST will be traversed and analyzed to identify instances of client-sided REST calls. When a REST call is detected, the system will extract relevant information such as the file path containing the REST call, the kind of REST call and the used URL.

Requirements

Functional requirements:

• FR1: Identification of new or modified REST calls: The GitHub action must Identify files containing newly created or modified REST calls.
• FR2: Output of REST calls' file path: The GitHub action must output the identified REST call's file path to the console
• FR3: Output of REST call's line: The GitHub action must output the line number in which the REST call is performed to the console
• FR4: Output HTTP method of REST calls: The GitHub action must output the HTTP method (e.g., GET, POST, PUT, DELETE) associated with each REST call to the console
• FR5: Output of REST call's URL: The GitHub action must output the URL of each identified REST call to the console

Non-functional requirements:

• NFR1: Performance: The Identification of client-sided REST calls must not take longer than 3 Minutes
• NFR2: Extendability: The GitHub action should be modular, and each functionality must be in its own method

---

Analysis

Dynamic Behavior

The following model illustrates the currently flawed code review process. Developers develop a feature, open a PR, and get it reviewed by other developers. If a reviewer discovers one or more flaws in the code, they request changes. Those requested changes are then implemented by the developer, and the PR is re-reviewed. Once every reviewer has approved the PR, maintainers review the PR. If they discover flaws, they also request changes. If not, the PR gets merged. If errors remain undiscovered during the review process, they will now get merged into the codebase and reduce the system's usability.

Steps for Testing:

The check result of an up-to-date test commit can be found here: https://github.com/ls1intum/Artemis/actions/runs/9390475871/job/25860430538

1. Push a commit containing changes in a client service file (eg. src/main/webapp/app/course/tutorial-groups/services/tutorial-group-free-period.service.ts)
2. Navigate to Checks
3. Open analysis-of-endpoint-connections
4. navigate to Run analysis-of-endpoint-connections-client
5. Verify that all Endpoints contained in changed files are in the output.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

Summary by CodeRabbit

• New Features

  • Introduced functionality to analyze TypeScript files for REST API calls, extract class properties, and resolve dynamic URLs.
  • Added a GitHub workflow to set up Node.js and JDK 21 for endpoint analysis.

• Improvements

  • Enhanced logging for REST API calls, including URLs, arguments, line numbers, and file paths.

• Chores

  • Updated project dependencies and TypeScript configuration for the analysis script.

implemented feedback

[az108]

Code LGTM and verified the testing steps

[sarpsahinalp]

There is a failing server test but I don't think it is related to your PR
testQuizSubmitNoDatabaseRequests(QuizMode) [1] quizMode=SYNCHRONIZED

[Jan-Thurner]

There is a failing server test but I don't think it is related to your PR testQuizSubmitNoDatabaseRequests(QuizMode) [1] quizMode=SYNCHRONIZED

There are no components on the server modified with this PR.

[rstief]

Code LGTM

[MarkusPaulsen]

Feedback in the code.

[coderabbitai]

Actionable comments posted: 2

[coderabbitai]

Actionable comments posted: 0

Outside diff range comments (1)

src/main/webapp/app/course/tutorial-groups/services/tutorial-group-free-period.service.ts (1)

Line range hint 84-86: Remove the redundant else clause to simplify the code.

-        } else {
-            return tutorialGroupFreePeriodDTO;
-        }

[coderabbitai]

Actionable comments posted: 2