-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Update naming convention in server and client coding guidelines
#8584
Development
: Update naming convention in server and client coding guidelines
#8584
Conversation
WalkthroughThe recent updates to the development guidelines focus on promoting a consistent naming convention throughout the project. The changes advocate for using Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reflects the changes as discussed in the meeting 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found some small mistakes in the description text - apart from these it looks good to me
e23a9d0
…ion-sceaming-case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the small fixes, looks good to me now!
…ion-sceaming-case
…ion-sceaming-case
…ion-sceaming-case
Development
: update naming convention in server and client guidelinesDevelopment
: Update naming convention in server and client guidelines
Development
: Update naming convention in server and client guidelinesDevelopment
: Update naming convention in server and client coding guidelines
Checklist
General
Motivation and Context
As discussed in the dev meeting (13.05.2024), we need to update the naming convention for constants in the server and client where constant names should adhere to the SCREAMING_SNAKE_CASE rule.
Description
Updated docs
Steps for Testing
Read the updated docs:
server docs
client docs
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review