Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Update naming convention in server and client coding guidelines #8584

Merged

Conversation

BBesrour
Copy link
Member

@BBesrour BBesrour commented May 13, 2024

Checklist

General

Motivation and Context

As discussed in the dev meeting (13.05.2024), we need to update the naming convention for constants in the server and client where constant names should adhere to the SCREAMING_SNAKE_CASE rule.

Description

Updated docs

Steps for Testing

Read the updated docs:
server docs
client docs

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked






Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@BBesrour BBesrour self-assigned this May 13, 2024
@BBesrour BBesrour requested a review from a team as a code owner May 13, 2024 10:58
Copy link

coderabbitai bot commented May 13, 2024

Walkthrough

The recent updates to the development guidelines focus on promoting a consistent naming convention throughout the project. The changes advocate for using SCREAMING_SNAKE_CASE for constants and transitioning to camelCase for methods and classes, enhancing readability and maintaining standardization. The guideline regarding prefixing private properties with "_" has been eliminated, streamlining the code style.

Changes

File Path Change Summary
.../guidelines/client.rst
.../guidelines/server.rst
Updated naming conventions: constants to use SCREAMING_SNAKE_CASE, methods and classes to use camelCase. Removed recommendation for "_" prefix on private properties. Logger convention remains unchanged.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes May 13, 2024
rstief
rstief previously approved these changes May 13, 2024
Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marlon-luca-bu
marlon-luca-bu previously approved these changes May 13, 2024
Copy link
Contributor

@marlon-luca-bu marlon-luca-bu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reflects the changes as discussed in the meeting 👍

Copy link
Contributor

@florian-glombik florian-glombik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found some small mistakes in the description text - apart from these it looks good to me

docs/dev/guidelines/server.rst Outdated Show resolved Hide resolved
docs/dev/guidelines/server.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@florian-glombik florian-glombik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the small fixes, looks good to me now!

@krusche krusche changed the title Development: update naming convention in server and client guidelines Development: Update naming convention in server and client guidelines May 17, 2024
@krusche krusche changed the title Development: Update naming convention in server and client guidelines Development: Update naming convention in server and client coding guidelines May 17, 2024
@krusche krusche added this to the 7.1.0 milestone May 17, 2024
@krusche krusche merged commit 7f31ba0 into develop May 17, 2024
9 of 10 checks passed
@krusche krusche deleted the chore/documentation/update-naming-convertion-sceaming-case branch May 17, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

None yet

8 participants