-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Fix link to PR naming convention in template
#8596
Development
: Fix link to PR naming convention in template
#8596
Conversation
WalkthroughThe update involves modifying the URL in the GitHub pull request template to point to a new location within the Artemis documentation. This change ensures that the link directing contributors to the naming conventions for GitHub pull requests is accurate and up-to-date. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (13)
.github/PULL_REQUEST_TEMPLATE.md (13)
Line range hint
4-5
: Headings should be surrounded by blank lines for better readability.-### Checklist +### Checklist
Line range hint
16-16
: Lists should be surrounded by blank lines for better readability.-#### General +#### General
Line range hint
24-24
: Lists should be surrounded by blank lines for better readability.-#### Server +#### Server
Line range hint
35-35
: Lists should be surrounded by blank lines for better readability.-#### Client +#### Client
Line range hint
51-51
: Lists should be surrounded by blank lines for better readability.-#### Changes affecting Programming Exercises +#### Changes affecting Programming Exercises
Line range hint
64-64
: Lists should be surrounded by blank lines for better readability.-### Motivation and Context +### Motivation and Context
Line range hint
73-73
: Lists should be surrounded by blank lines for better readability.-### Description +### Description
Line range hint
92-92
: Lists should be surrounded by blank lines for better readability.-### Testserver States +### Testserver States
Line range hint
93-93
: Trailing spaces found. Remove trailing spaces for cleaner formatting.-#### Performance Review +#### Performance Review
Line range hint
95-95
: Headings should be surrounded by blank lines for better readability.-#### Code Review +#### Code Review
Line range hint
98-98
: Headings should be surrounded by blank lines for better readability.-#### Manual Tests +#### Manual Tests
Line range hint
101-101
: Headings should be surrounded by blank lines for better readability.-### Test Coverage +### Test Coverage
Line range hint
78-83
: Images should have alternate text (alt text) for accessibility.-![](https://byob.yarr.is/ls1intum/Artemis/artemis-test1) -![](https://byob.yarr.is/ls1intum/Artemis/artemis-test2) -![](https://byob.yarr.is/ls1intum/Artemis/artemis-test3) -![](https://byob.yarr.is/ls1intum/Artemis/artemis-test4) -![](https://byob.yarr.is/ls1intum/Artemis/artemis-test5) -![](https://byob.yarr.is/ls1intum/Artemis/artemis-test6) +![Test Server 1](https://byob.yarr.is/ls1intum/Artemis/artemis-test1) +![Test Server 2](https://byob.yarr.is/ls1intum/Artemis/artemis-test2) +![Test Server 3](https://byob.yarr.is/ls1intum/Artemis/artemis-test3) +![Test Server 4](https://byob.yarr.is/ls1intum/Artemis/artemis-test4) +![Test Server 5](https://byob.yarr.is/ls1intum/Artemis/artemis-test5) +![Test Server 6](https://byob.yarr.is/ls1intum/Artemis/artemis-test6)
Development
: Fixing link to naming convention in PR templateDevelopment
: Fix link to naming convention in PR template
Development
: Fix link to naming convention in PR templateDevelopment
: Fix link to PR naming convention in PR template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing change!
…ink-in-pr-template
…ink-in-pr-template
…ink-in-pr-template
Development
: Fix link to PR naming convention in PR templateDevelopment
: Fix link to PR naming convention in template
Checklist
General
on a test server.Description
With the new development process the link in the PR template that should lead to the PR naming conventions broke. This is addressed by this PR and updates the link to the guidelines.
Steps for Testing
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review