Development: Speedup docker image cleanup information retrieval

[krusche]

Checklist

General

• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I strictly followed the server coding and design guidelines.

Motivation and Context

The query to retrieve the docker image usage information was slow on production (with > 300.000 builds). It was executed too often and on multiple core nodes, potentially at the same time.

Description

• Add an index to make the query significantly faster and execute it less often (only on the main node with active scheduling): essential changes in SharedQueueManagementService.java
• This PR also delays some startup tasks to potentially make the server app start faster
• It removes ArtemisSpringManagedContext which was only used for debugging purposes and not really needed any more

Note: only code review is needed

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

[coderabbitai]

Walkthrough

The recent updates focus on optimizing the application's initialization process by deferring certain operations until the application is fully ready. This involves replacing direct method calls and @PostConstruct annotations with @EventListener(ApplicationReadyEvent.class). Additionally, there are minor adjustments to bean configurations and the introduction of TODO comments suggesting further enhancements. These changes aim to enhance application startup performance and ensure critical operations occur only after the application context is fully initialized.

Changes

File Path	Change Summary
src/main/java/de/tum/in/www1/artemis/config/MetricsBean.java	Added event listener for ApplicationReadyEvent, modified initialization method, and adjusted scheduling for metrics.
src/main/java/de/tum/in/www1/artemis/config/localvcci/LocalCIConfiguration.java	Added TODO comments suggesting reconsideration of bean creation after application startup.
src/main/java/de/tum/in/www1/artemis/service/PlantUmlService.java	Added EventListener method for handling ApplicationReadyEvent.
src/main/java/de/tum/in/www1/artemis/service/TitleCacheEvictionService.java	Added EventListener method for handling ApplicationReadyEvent and logic for Hibernate listener registration.
src/main/java/de/tum/in/www1/artemis/service/connectors/BuildScriptProviderService.java	Changed cacheOnBoot method to use @EventListener(ApplicationReadyEvent.class).
src/main/java/de/tum/in/www1/artemis/service/connectors/aeolus/AeolusTemplateService.java	Changed cacheOnBoot method to use @EventListener(ApplicationReadyEvent.class).
src/main/java/de/tum/in/www1/artemis/service/connectors/localci/SharedQueueManagementService.java	Added ProfileService dependency, modified constructor, and updated method to check scheduling status before execution.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4f04205 and 7e6c5d0.

Files selected for processing (5)

• src/main/java/de/tum/in/www1/artemis/config/MetricsBean.java (6 hunks)
• src/main/java/de/tum/in/www1/artemis/service/PlantUmlService.java (2 hunks)
• src/main/java/de/tum/in/www1/artemis/service/TitleCacheEvictionService.java (2 hunks)
• src/main/java/de/tum/in/www1/artemis/service/connectors/BuildScriptProviderService.java (2 hunks)
• src/main/java/de/tum/in/www1/artemis/service/connectors/aeolus/AeolusTemplateService.java (2 hunks)

Files skipped from review as they are similar to previous changes (5)

• src/main/java/de/tum/in/www1/artemis/config/MetricsBean.java
• src/main/java/de/tum/in/www1/artemis/service/PlantUmlService.java
• src/main/java/de/tum/in/www1/artemis/service/TitleCacheEvictionService.java
• src/main/java/de/tum/in/www1/artemis/service/connectors/BuildScriptProviderService.java
• src/main/java/de/tum/in/www1/artemis/service/connectors/aeolus/AeolusTemplateService.java

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[laurenzfb]

code looks reasonable to me