Model extending #1661
Open
Model extending #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
InstallLunar class should be also updated right? It currently uses |
glennjacobs
reviewed
Apr 24, 2024
| @@ -175,6 +175,8 @@ public function register(): void | |||
| $this->app->singleton(DiscountManagerInterface::class, function ($app) { | |||
| return $app->make(DiscountManager::class); | |||
| }); | |||
|
|
|||
| \Lunar\Facades\ModelManifest::register(); // Facade is the same name as the class, change?? | |||
There was a problem hiding this comment.
Looks like we need to address the comment.
There was a problem hiding this comment.
I've removed the comment, not sure what needs changing as it's a common pattern in Laravel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks to build on the current work done for model extending and includes but not limited to the following changes:
morphMapinstead of having concrete classes in the database for polymorphic relationshipsnewFactorymethod didn't like having the return type.addDirguessContractClassto take namespace into account as not all Lunar models (from addons) will have the same namespaceaddDirectorymethod to prevent excessive calls toreplaceoraddmethods.modelClass()App\Models\MyProductinstead ofApp\Models\Productit will still use the correct table name.observemethod on models that useHasModelExtendingto forward to the custom class even if observe is called on the Lunar model.Set as draft for the moment as there is a fair amount of changes so just want to double check before hitting the button.