Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Update Stripe dependencies #1715

Open
wants to merge 6 commits into
base: 1.x
Choose a base branch
from

Conversation

lguichard
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 9:00am

@alecritson
Copy link
Collaborator

Thanks @lguichard This seems like quite the jump in versions, was there any upgrade guides that need to be considered if not already done?

@alecritson alecritson added this to the v1.0 milestone May 3, 2024
@adevade
Copy link
Contributor

adevade commented May 7, 2024

But it has to be updated, right? It seems a lot of things has been deprecated and removed from the API since v7 from 2022.

Useful links:

Migration Guide for v8
Migration Guide for v9
Migration Guide for v10
Migration Guide for v11 (Skipped)
Migration Guide for v12
Migration Guide for v13
Release Notes for v14

@alecritson
Copy link
Collaborator

Yup it certainly needs to be on the latest version as long as anything that needs updating on the Stripe package is considered.

@lguichard
Copy link
Contributor Author

I will update stripe package with new dependencies.

@alecritson
Copy link
Collaborator

@lguichard I've had a little look through the migration guides and I don't think there is too much we need to worry about, I've done one update to the StripeManager class but apart from that I think we're good.

@adevade
Copy link
Contributor

adevade commented May 23, 2024

@alecritson Why did you revert the typing?

@alecritson
Copy link
Collaborator

@alecritson Why did you revert the typing?

It was already covered by a commit on 1.0 so actually created a conflict because this branch hadn't been updated. The typings are still there 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants