Add attribute data to ProductOption and ProductOptionValue
#1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds attribute data to
ProductOptionandProductOptionValue.It will be useful for storing meta data related to a specific option (such as a description, or a link to a sizing chart) and to a specific option value (such as a hex value for a color, or a short description).
It hasn't been tested yet, and no UI has been added, since I didn't know if this would get accepted. It has previously been requested/discussed here: #1296
If you agree i can clean it up, test it and add a UI to the panel. Or feel free to push changes as necessary. 👍
Off topic
I also agree with the linked discussion that it would be useful to have a handle on
ProductOptionValuefor usage in query strings for example. What are your thoughts on this?