[Spring cleaning] Refactor migrations #1737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks @adevade @glennjacobs This looks like something we should get in (if wanted) before too much else gets merged to give us a good baseline. |
glennjacobs
approved these changes
May 22, 2024
Maybe run this on an existing site to ensure nothing weird happens before merging? |
|
@glennjacobs Yeah, I have not tested for that. I don't believe there should be any problems though. |
|
Just ran this on the starter kit and didn't come against any issues so if everyone is happy @glennjacobs I guess it can go in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is probably easiest reviewed commit by commit instead of all changes at once.
Just some spring cleaning and standardization of the migration classes. I converted all to anonymous classes, like Laravel did during the 10.x releases.
Removed PHPDoc blocks, since they were not always there and less clutter.
All tests still passing locally.
Feel free to request changes or revert single commits if you don't like some of the changes.