Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localizable strings comments #283

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

tomlokhorst
Copy link
Collaborator

@tomlokhorst tomlokhorst commented Oct 24, 2016

Implements #232, continuation of #235

I've merged the current master branch into @nolanw's code, making it all Swift 3.

Todo:

  • Multiline or multi-part comments should be separated by \n
  • Comments should be printed in generated code
  • All tests should succeed
  • Consider splitting comment parser from localized strings parser [1]
  • Consider moving strings parser to separate library

[1]: Instead of flat out replacing the existing LocalizedStrings parser, we could split out the comments parser. That way, if there's an error in our own parser, the localized strings will still be generated, just with missing comments.

tomlokhorst and others added 2 commits October 24, 2016 18:27
@hujunfeng
Copy link
Contributor

Any plan to continue and finish this work? The last update of this MR was 1.5 years ago.

If no one is going to pick it up anytime soon, I would like to give it try.

@nolanw
Copy link

nolanw commented Apr 7, 2018

No plans from me, I ran outta steam.

@tomlokhorst
Copy link
Collaborator Author

We sort of stopped with this PR when @mac-cain13 and I realised we didn't want to replace your Strings parser, but only augment it.

So only build a Strings Comment parser, and combine that with the existing Strings parser. That way, existing file won't break if the new parser isn't perfect.

Anyway, that was the idea, but we never did anything more with it.

@anton-kaliuzhnyi-altexsoft

@tomlokhorst Are we going to see #232 in production any time soon, please?

@mac-cain13 mac-cain13 marked this pull request as draft April 24, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants