Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaces with Gateway API #4853

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

joaoferrao
Copy link

@joaoferrao joaoferrao commented Mar 29, 2024

Description

Addresses #4849

How Has This Been Tested?

  • Test A
  • Test B

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

Tasks

  • [backend] Create HTTP Route
  • [backend] Delete HTTP Route
  • [frontend] Visualise options (Ingress vs. HTTPRoute/GatewayAPI
  • [frontend] Form for HTTP Route options
  • [frontend] Submit with HTTP Route options

@joaoferrao
Copy link
Author

joaoferrao commented Mar 29, 2024

@dy46 I'm not acquainted with TypeScript but I'm willing to give it a go if you help me point out what else I should pay attention to, besides

Copy link
Member

@dy46 dy46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you still working on the backend portion?

mage_ai/cluster_manager/kubernetes/workload_manager.py Outdated Show resolved Hide resolved
@dy46
Copy link
Member

dy46 commented Apr 2, 2024

also here is where you would want to update the frontend:

const k8sSettingsFields = useMemo(() => (

@joaoferrao
Copy link
Author

are you still working on the backend portion?

Until I'm ready to test anything with the frontend, I'm done with the backend changes - although I (or someone else) will find something to change later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants