Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPS REST "A shipment cannot have a KGS/IN or LBS/CM or OZS/CM as its unit of measurements" #38618

Open
1 of 5 tasks
sanmic opened this issue Apr 15, 2024 · 40 comments · May be fixed by #38673
Open
1 of 5 tasks

UPS REST "A shipment cannot have a KGS/IN or LBS/CM or OZS/CM as its unit of measurements" #38618

sanmic opened this issue Apr 15, 2024 · 40 comments · May be fixed by #38673
Assignees
Labels
Area: Shipping Component: Ups Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@sanmic
Copy link

sanmic commented Apr 15, 2024

Preconditions and environment

Magento version 2.4.7

Steps to reproduce

Set European Union as Origin of the Shipment in Sales->Delivery Methods->UPS

Expected result

UPS rates is visible in checkout and cart.

Actual result

No UPS rates is visible in checkout and cart.

Additional information

Seems like UnitOfMeasurement is hardcoded to "IN".
If you have European Union (other origins may experience the same problem) as Origin of the Shipment this will cause an error in the UPS REST request:
"A shipment cannot have a KGS/IN or LBS/CM or OZS/CM as its unit of measurements"

1147 foreach ($rowRequest->getPackages() as $package) {
1148 $rateParams['RateRequest']['Shipment']['Package'][] = [
1149 "PackagingType" => [
1150 "Code" => "{$params['48_container']}",
1151 "Description" => "Packaging"
1152 ],
1153 "Dimensions" => [
1154 "UnitOfMeasurement" => [
1155 "Code" => "IN",
1156 "Description" => "Inches"
1157 ],
1158 "Length" => "5",
1159 "Width" => "5",
1160 "Height" => "5"
1161 ],
1162 "PackageWeight" => [
1163 "UnitOfMeasurement" => [
1164 "Code" => "{$rowRequest->getUnitMeasure()}"
1165 ],
1166 "Weight" => "{$this->_getCorrectWeight($package['weight'])}"
1167 ]
1168 ];
1169 }

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Apr 15, 2024

Hi @sanmic. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@sanmic
Copy link
Author

sanmic commented Apr 15, 2024

@magento give me 2.4-develop instance - upcoming 2.4.x release

Copy link

Hi @sanmic. Thank you for your request. I'm working on Magento instance for you.

Copy link

m2-assistant bot commented Apr 15, 2024

Hi @sanmic! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7 Indicates original Magento version for the Issue report. label Apr 15, 2024
Copy link

@engcom-Dash engcom-Dash self-assigned this Apr 15, 2024
Copy link

m2-assistant bot commented Apr 15, 2024

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

Copy link

m2-assistant bot commented Apr 16, 2024

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@sanmic
Copy link
Author

sanmic commented Apr 16, 2024

@magento give me 2.4-develop instance - upcoming 2.4.x release

Copy link

Hi @sanmic. Thank you for your request. I'm working on Magento instance for you.

Copy link

@sanmic
Copy link
Author

sanmic commented Apr 16, 2024

To reproduce:
Sales -> Delivery methods -> UPS
Set Origin of the Shipment to Shipments Originating in the European Union
Set Weight Unit to KGS

No UPS rates is visible in frontend.

If Weight Unit is set to LBS rates is visible in fronted.
I can see by myself that LBS is hardcoded in the core files.

REST-EU-Origin-KGS1
REST-EU-Origin-KGS2
REST-EU-Origin-LGS1
REST-EU-Origin-LGS2
REST-US-Origin1
REST-US-Origin2

@sanmic
Copy link
Author

sanmic commented Apr 16, 2024 via email

@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Ups Area: Shipping labels Apr 17, 2024
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Apr 17, 2024
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Apr 17, 2024
@m2-community-project m2-community-project bot moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board Apr 17, 2024
@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Apr 17, 2024
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Apr 17, 2024
@engcom-Bravo
Copy link
Contributor

Hi @sanmic,

Our internal team is working on the issue and we have following updates

Please refer the Comments:

#38618 (comment)

#38618 (comment)

Thanks.

@digitalrisedorset
Copy link

@magento I am working on this

@digitalrisedorset
Copy link

Do we have some UPS access details to use to replicate the issue on a local environment?

@sanmic
Copy link
Author

sanmic commented Apr 25, 2024

@digitalrisedorset Have you been able to get UPS access details?

@digitalrisedorset
Copy link

digitalrisedorset commented Apr 26, 2024

@sanmic no I have not. I got as far as creating the UPS account but a lot of settings were required and by the time I had the setup created to handle the task, I was doomed to have setup the UPS service differently to what is needed to replicate the issue we have in this ticket. So, I'd like instead to verify if I can use a test UPS environment that is ready to use to just perform the Magento test and fix after this

@sanmic
Copy link
Author

sanmic commented Apr 26, 2024

@sanmic no I have not. I got as far as creating the UPS account but a lot of settings were required and by the time I had the setup created to handle the task, I was doomed to have setup the UPS service differently to what is needed to replicate the issue we have in this ticket. So, I'd like instead to verify if I can use a test UPS environment that is ready to use to just perform the Magento test and fix after this

@digitalrisedorset I guess I can create a UPS test app / credentials so you can continue your work.
I'll need a Callback URL and an email or similar to send the details.

@digitalrisedorset
Copy link

Hi @sanmic , I have setup a demo site at https://demo.digitalrisedorset.co.uk/ and the email may be herve@digitalrisedorset.co.uk. Many thanks

@sanmic
Copy link
Author

sanmic commented Apr 26, 2024

@digitalrisedorset Check you email :)

@digitalrisedorset
Copy link

digitalrisedorset commented Apr 26, 2024

@sanmic .. we should be almost there. I have setup UPS, to start with, I'd like to verify I can get it to work as per the screenshots above, I have setup the credentials with European origin and yet Pounds rather than Kgs. I have also used an address from the states. I attach both screenshots. Am I missing something?

I will start troubleshooting either way, thank you very much indeed

Screenshot from 2024-04-26 12-22-49
Screenshot from 2024-04-26 12-22-06

@sanmic
Copy link
Author

sanmic commented Apr 26, 2024

@digitalrisedorset I think you have to set "Origin of the Shipment" to, for example, "Shipments Originating in United States".
The weight unit parameter may depend on the Magentos origin settings, Sales->Shipping settings->Origin, but I'm not 100% sure.
Our Origin, for example, is Sweden which uses KGS. If origin is US which use LBS.
Do some testing based on that, I think you will figure it out.

@digitalrisedorset
Copy link

@sanmic I am not lucky just yet.. I have a successful response and in fact, some times for possible delivery time do appear. Unfortunately, it does return eventually the error message that UPS is not available. I will try to read more on UPS before debugging further. I apologise, it seems to be something that will take a while.

{
   "RateResponse":{
      "Response":{
         "ResponseStatus":{
            "Code":"1",
            "Description":"Success"
         },
         "Alert":[
            {
               "Code":"110971",
               "Description":"Your invoice may vary from the displayed reference rates"
            },
            {
               "Code":"120902",
               "Description":"Negotiated rates cannot be returned without a valid account number."
            },
            {
               "Code":"111685",
               "Description":"TPFCNegotiatedRatesIndicator is applicable only for Third party/Freight Collect shipments."
            }
         ],
         "TransactionReference":{
            "CustomerContext":"Rating and Service"
         }
      },
      "RatedShipment":[
         {
            "Disclaimer":{
               "Code":"05",
               "Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
            },
            "Service":{
               "Code":"01",
               "Description":""
            },
            "RatedShipmentAlert":[
               {
                  "Code":"120902",
                  "Description":"Negotiated rates cannot be returned without a valid account number."
               },
               {
                  "Code":"110971",
                  "Description":"Your invoice may vary from the displayed reference rates"
               }
            ],
            "BillingWeight":{
               "UnitOfMeasurement":{
                  "Code":"LBS",
                  "Description":"Pounds"
               },
               "Weight":"2.0"
            },
            "TransportationCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"106.66"
            },
            "ServiceOptionsCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"0.00"
            },
            "TotalCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"106.66"
            },
            "GuaranteedDelivery":{
               "BusinessDaysInTransit":"1",
               "DeliveryByTime":"10:30 A.M."
            },
            "RatedPackage":{
               "TransportationCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"106.66"
               },
               "ServiceOptionsCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"0.00"
               },
               "TotalCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"106.66"
               },
               "Weight":"2.0",
               "BillingWeight":{
                  "UnitOfMeasurement":{
                     "Code":"LBS",
                     "Description":"Pounds"
                  },
                  "Weight":"2.0"
               }
            }
         },
         {
            "Disclaimer":{
               "Code":"05",
               "Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
            },
            "Service":{
               "Code":"02",
               "Description":""
            },
            "RatedShipmentAlert":[
               {
                  "Code":"120902",
                  "Description":"Negotiated rates cannot be returned without a valid account number."
               },
               {
                  "Code":"110971",
                  "Description":"Your invoice may vary from the displayed reference rates"
               }
            ],
            "BillingWeight":{
               "UnitOfMeasurement":{
                  "Code":"LBS",
                  "Description":"Pounds"
               },
               "Weight":"2.0"
            },
            "TransportationCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"42.22"
            },
            "ServiceOptionsCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"0.00"
            },
            "TotalCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"42.22"
            },
            "GuaranteedDelivery":{
               "BusinessDaysInTransit":"2"
            },
            "RatedPackage":{
               "TransportationCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"42.22"
               },
               "ServiceOptionsCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"0.00"
               },
               "TotalCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"42.22"
               },
               "Weight":"2.0",
               "BillingWeight":{
                  "UnitOfMeasurement":{
                     "Code":"LBS",
                     "Description":"Pounds"
                  },
                  "Weight":"2.0"
               }
            }
         },
         {
            "Disclaimer":{
               "Code":"05",
               "Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
            },
            "Service":{
               "Code":"03",
               "Description":""
            },
            "RatedShipmentAlert":[
               {
                  "Code":"120902",
                  "Description":"Negotiated rates cannot be returned without a valid account number."
               },
               {
                  "Code":"110971",
                  "Description":"Your invoice may vary from the displayed reference rates"
               }
            ],
            "BillingWeight":{
               "UnitOfMeasurement":{
                  "Code":"LBS",
                  "Description":"Pounds"
               },
               "Weight":"2.0"
            },
            "TransportationCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"15.12"
            },
            "ServiceOptionsCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"0.00"
            },
            "TotalCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"15.12"
            },
            "RatedPackage":{
               "TransportationCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"15.12"
               },
               "ServiceOptionsCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"0.00"
               },
               "TotalCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"15.12"
               },
               "Weight":"2.0",
               "BillingWeight":{
                  "UnitOfMeasurement":{
                     "Code":"LBS",
                     "Description":"Pounds"
                  },
                  "Weight":"2.0"
               }
            }
         },
         {
            "Disclaimer":{
               "Code":"05",
               "Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
            },
            "Service":{
               "Code":"12",
               "Description":""
            },
            "RatedShipmentAlert":[
               {
                  "Code":"120902",
                  "Description":"Negotiated rates cannot be returned without a valid account number."
               },
               {
                  "Code":"110971",
                  "Description":"Your invoice may vary from the displayed reference rates"
               }
            ],
            "BillingWeight":{
               "UnitOfMeasurement":{
                  "Code":"LBS",
                  "Description":"Pounds"
               },
               "Weight":"2.0"
            },
            "TransportationCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"33.64"
            },
            "ServiceOptionsCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"0.00"
            },
            "TotalCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"33.64"
            },
            "GuaranteedDelivery":{
               "BusinessDaysInTransit":"3"
            },
            "RatedPackage":{
               "TransportationCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"33.64"
               },
               "ServiceOptionsCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"0.00"
               },
               "TotalCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"33.64"
               },
               "Weight":"2.0",
               "BillingWeight":{
                  "UnitOfMeasurement":{
                     "Code":"LBS",
                     "Description":"Pounds"
                  },
                  "Weight":"2.0"
               }
            }
         },
         {
            "Disclaimer":{
               "Code":"05",
               "Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
            },
            "Service":{
               "Code":"13",
               "Description":""
            },
            "RatedShipmentAlert":[
               {
                  "Code":"120902",
                  "Description":"Negotiated rates cannot be returned without a valid account number."
               },
               {
                  "Code":"110971",
                  "Description":"Your invoice may vary from the displayed reference rates"
               }
            ],
            "BillingWeight":{
               "UnitOfMeasurement":{
                  "Code":"LBS",
                  "Description":"Pounds"
               },
               "Weight":"2.0"
            },
            "TransportationCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"97.20"
            },
            "ServiceOptionsCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"0.00"
            },
            "TotalCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"97.20"
            },
            "GuaranteedDelivery":{
               "BusinessDaysInTransit":"1"
            },
            "RatedPackage":{
               "TransportationCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"97.20"
               },
               "ServiceOptionsCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"0.00"
               },
               "TotalCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"97.20"
               },
               "Weight":"2.0",
               "BillingWeight":{
                  "UnitOfMeasurement":{
                     "Code":"LBS",
                     "Description":"Pounds"
                  },
                  "Weight":"2.0"
               }
            }
         },
         {
            "Disclaimer":{
               "Code":"05",
               "Description":"Rate excludes VAT. Rate includes a fuel surcharge, but excludes taxes, duties and other charges that may apply to the shipment."
            },
            "Service":{
               "Code":"14",
               "Description":""
            },
            "RatedShipmentAlert":[
               {
                  "Code":"120902",
                  "Description":"Negotiated rates cannot be returned without a valid account number."
               },
               {
                  "Code":"110971",
                  "Description":"Your invoice may vary from the displayed reference rates"
               }
            ],
            "BillingWeight":{
               "UnitOfMeasurement":{
                  "Code":"LBS",
                  "Description":"Pounds"
               },
               "Weight":"2.0"
            },
            "TransportationCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"141.84"
            },
            "ServiceOptionsCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"0.00"
            },
            "TotalCharges":{
               "CurrencyCode":"USD",
               "MonetaryValue":"141.84"
            },
            "GuaranteedDelivery":{
               "BusinessDaysInTransit":"1",
               "DeliveryByTime":"8:00 A.M."
            },
            "RatedPackage":{
               "TransportationCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"141.84"
               },
               "ServiceOptionsCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"0.00"
               },
               "TotalCharges":{
                  "CurrencyCode":"USD",
                  "MonetaryValue":"141.84"
               },
               "Weight":"2.0",
               "BillingWeight":{
                  "UnitOfMeasurement":{
                     "Code":"LBS",
                     "Description":"Pounds"
                  },
                  "Weight":"2.0"
               }
            }
         }
      ]
   }
}

@digitalrisedorset
Copy link

I have looked into UPS guides further. I have worked out that the setup can go wrong with the information: User ID, Password, Gateway URL and origin setting:

  • User ID: I have assigned the Client ID value
  • Password: I have assigned the Client Secret value
  • Gateway URL: I left this to the system value: https://wwwcie.ups.com/api/rating/
  • Origin and set up the right address: I have US, California, 90034 (there is no city, street address defined at the moment)

Could we double check these information settings before we go any further?

#https://amasty.com/knowledge-base/how-to-set-up-ups-in-magento-2.html
#https://www.ups.com/upsdeveloperkit

@sanmic
Copy link
Author

sanmic commented Apr 27, 2024

@digitalrisedorset I can confirm those settings work for me as long as I have LBS as weight unit.
Changing the "Origin of the Shipment" to "Europe", weight to KGS and the "Shipping Origin" to our address, "77463, Dalarnas Län, Avesta, Sweden", will break it.

I've just spent a short time on this, but this is what I've found out so far.
UPS will return rates if:

  • Magento origin is set to a US address (will probably work with Canada and a lot of other countries as well)
  • UPS weight unit is set to: LBS
  • UPS origin setting doesn't matter if above is set.

UPS will NOT return rates if:

  • UPS weight unit is set to; KGS

UPS will NOT return rates if:

  • Magento origin is set to "77463, Dalarnas Län, Avesta, Sweden"

I want to setup my store like this:

  • Magento origin: "77463, Dalarnas Län, Avesta, Sweden"
  • UPS weight unit is set to: KGS
  • UPS origin: Europe

I can change line 1155 in /vendor/magento/module-ups/Model/Carrier.php -> "Code" => "CM", to make it work with above settings.

@digitalrisedorset
Copy link

I have a draft PR in place for this issue. The changes in the PR do resolve the problem but I'd like to check if we can also ensure that the integration can work with the other modes without being restricted to Inches before I finalise the PR

see: #38673

@digitalrisedorset
Copy link

@sanmic in the same way that Inch is hard-coded, I can see the dimensions for the request is also hard-coded. This is just below the place that you had patched:

"Length" => "5",
                    "Width" => "5",
                    "Height" => "5"

I have changed the part you recommended us to change but I have not changed the dimensions. Would you be able to comment whether we should change it or not?

@github-jira-sync-bot github-jira-sync-bot added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Apr 29, 2024
@sanmic
Copy link
Author

sanmic commented Apr 29, 2024

@digitalrisedorset Yes, I've noticed that also.
I cannot find an option to set or use dimensions in the UPS settings section so I guess the hardcoded 5x5x5 is there for some kind of fallback 🤔

@m2-community-project m2-community-project bot removed the Progress: PR Created Indicates that Pull Request has been created to fix issue label Apr 30, 2024
@digitalrisedorset
Copy link

@sanmic the PR is now in review, I have tested today all the use cases you have mentioned and all is working with the simple changes added.

@github-jira-sync-bot github-jira-sync-bot added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Apr 30, 2024
@digitalrisedorset
Copy link

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Shipping Component: Ups Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

7 participants