Added a validation for the dimension and enable KGS to be a possible …

[digitalrisedorset]

The UPS integration currently only works for the unit of measurement Inches. European shops who want to use UPS are not able to setup their Magento integration with Kgs.

Description (*)

The change enables the UPS module to work interchangeably with Inch or with Cm. The change is made when the UPS mode works with API integration.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes UPS REST "A shipment cannot have a KGS/IN or LBS/CM or OZS/CM as its unit of measurements" #38618

Manual testing scenarios (*)

The scope of the PR changes one mode of the UPS integration and that is the Rest mode with the UPS integration:
Enable the UPS shipping method
Setup the type with the Rest mode
The shipment origin setting requires a Postcode

Use case 1: this currently does not return rates and that is what the fix changes
Set the Shipping origin to be European
Set the weight unit in Kgs
Ensure the currency for the country of origin is allowed in the system
validate UPS returns some shipping methods

Use case 2:: backward compliance test
Set the Shipping origin to be United States
Set the weight unit in Lbs
Ensure the currency for the country of origin is allowed in the system
validate UPS returns some shipping methods

Use case 3:: backward compliance test / the unit Kg is not authorised for US origin
Set the Shipping origin to be United States
Set the weight unit in Kgs
Ensure the currency for the country of origin is allowed in the system
validate UPS does not return any shipping methods

Questions or comments

I have attempted to add integration tests. There are many in place and I was hopeful to get at least one added for the use case of unit measure 'Kg' and origin 'EU' but I found that the blocker is that these tests mocks when the API call is triggered and that means we can't add tests for this issue as far as I see it

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @digitalrisedorset. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[digitalrisedorset]

@magento run all tests

[sanmic]

@digitalrisedorset What's the current status of this ticket?

[digitalrisedorset]

@sanmic This PR is awaiting review and its change resolves the issue for the API mode of the shipment module