New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: WAI-ARIA roles nesting wrong in menu #38617
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @mirianfalconi. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@@ -246,7 +246,7 @@ protected function _getHtml( | |||
} | |||
|
|||
$html .= '<li ' . $this->_getRenderedMenuItemAttributes($child) . '>'; | |||
$html .= '<a href="' . $child->getUrl() . '" ' . $outermostClassCode . '><span>' . $this->escapeHtml( | |||
$html .= '<a href="' . $child->getUrl() . '" ' . $outermostClassCode . ' role="menuitem"><span>' . $this->escapeHtml( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$html .= '<a href="' . $child->getUrl() . '" ' . $outermostClassCode . ' role="menuitem"><span>' . $this->escapeHtml( | |
$html .= '<a href="' . $child->getUrl() . '" ' | |
. $outermostClassCode | |
. ' role="menuitem"><span>' | |
. $this->escapeHtml( |
To fix coding standard:
FILE: /var/www/html/app/code/Magento/Theme/Block/Html/Topmenu.php
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
249 | WARNING | Line exceeds 120 characters; contains 129 characters
@magento run all tests |
@magento run all tests |
Fixed Issues (if relevant)
Manual testing scenarios (*)