Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: WAI-ARIA roles nesting wrong in menu #38617

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

mirianfalconi
Copy link

Fixed Issues (if relevant)

  1. Fixes Accessibility: WAI-ARIA roles nesting wrong in menu #35889

Manual testing scenarios (*)

  1. Open the Lighthouse and do the Accessibily analysis without this PR

Screenshot from 2024-04-14 11-52-16

  1. Open the Lighthouse and do the Accessibily analysis with this PR

Screenshot from 2024-04-14 11-56-37

Copy link

m2-assistant bot commented Apr 14, 2024

Hi @mirianfalconi. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@mirianfalconi
Copy link
Author

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 16, 2024
@@ -246,7 +246,7 @@ protected function _getHtml(
}

$html .= '<li ' . $this->_getRenderedMenuItemAttributes($child) . '>';
$html .= '<a href="' . $child->getUrl() . '" ' . $outermostClassCode . '><span>' . $this->escapeHtml(
$html .= '<a href="' . $child->getUrl() . '" ' . $outermostClassCode . ' role="menuitem"><span>' . $this->escapeHtml(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$html .= '<a href="' . $child->getUrl() . '" ' . $outermostClassCode . ' role="menuitem"><span>' . $this->escapeHtml(
$html .= '<a href="' . $child->getUrl() . '" '
. $outermostClassCode
. ' role="menuitem"><span>'
. $this->escapeHtml(

To fix coding standard:

FILE: /var/www/html/app/code/Magento/Theme/Block/Html/Topmenu.php


FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE


249 | WARNING | Line exceeds 120 characters; contains 129 characters

@mirianfalconi
Copy link
Author

@magento run all tests

@mirianfalconi
Copy link
Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review
Projects
Pull Requests Dashboard
  
Review in Progress
Development

Successfully merging this pull request may close these issues.

Accessibility: WAI-ARIA roles nesting wrong in menu
4 participants