New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensured the Page cache identifier is read in the same way and checking and saving the cache identifier #38646
base: 2.4-develop
Are you sure you want to change the base?
Conversation
…ifier with store configuration
Hi @digitalrisedorset. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
Hi, Internal team has started to work on it Thanks. |
…tifier is created
…to work with non library models for the cache logic
…ier logic external to lib folder
Ensured the Page cache identifier is read in the same way and checking and saving the cache identifier
The change consists using a new model that pulls the design + store cache parameters. This model is injected in both places that needs these cache information. This has meant a plugin was removed in favour of this model.
Description (*)
When the page gets loaded, the FPC checks if the page cache identifier is already saved in the cache. This reading checks the server environment variables (eg: PARAM_RUN_CODE).
When the page has been rendered, the page cache identifier is saved to prevent the same page to be reloaded the next loads the same version for it. The identifier was currently saved differently to the identifier created in the reading phase and that was breaking the cache
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Test 1: Backward compatibility - The FPC works
Setup the Magento store with no environment variable
PARAM_RUN_CODE
,PARAM_RUN_TYPE
, ensure the Full page cache is enabled and set the developer mode active, load a page twice and verify the second load is cached by checking the headerX-Magento-Cache-Debug
Test 2: Test the fault - The FPC works with environment variables
Setup the Magento store with some environment variables
PARAM_RUN_CODE
,PARAM_RUN_TYPE
, ensure the Full page cache is enabled and set the developer mode active, load a page twice and verify the second load is cached by checking the headerX-Magento-Cache-Debug
Questions or comments
Contribution checklist (*)