New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#38659 - Fix order status update #38661
base: 2.4-develop
Are you sure you want to change the base?
#38659 - Fix order status update #38661
Conversation
Hi @Nuranto. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
Actually, looking at this code, I wonder if we shouldn't take the opportunity to do a more thorough refactoring. This PR is a conveninent quick fix for the issue, but there's more to do : The AddComment controller should use the OrderService::addComment service, and the state/status check that I added here should be done in the Order::addStatusHistory class. We will then need to revise the tests accordingly.... It's a too big task for me, especially without being sure that the PR will be approved, I think it would be worth asking for the opinion of the Magento architects. What do you think ? |
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)