Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#38671 - Fix sales rules when rule is applied only on shipping amount #38680

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

#38671 - Fix sales rules when rule is applied only on shipping amount #38680

wants to merge 1 commit into from

Conversation

Nuranto
Copy link
Contributor

@Nuranto Nuranto commented Apr 30, 2024

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [Issue] Sales Rules regression in 2.4.7 #38671

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 30, 2024

Hi @Nuranto. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 30, 2024
@Nuranto
Copy link
Contributor Author

Nuranto commented Apr 30, 2024

@magento run all tests

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Apr 30, 2024
@m2-community-project m2-community-project bot added Progress: pending review Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Apr 30, 2024
@Nuranto
Copy link
Contributor Author

Nuranto commented May 1, 2024

@magento run WebAPI Tests, Functional Tests EE, Functional Tests B2B

Den4ik
Den4ik approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@Den4ik Den4ik left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ I'm agree with rolling back this changes
@Nuranto Thanks for contribution

@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in Pull Requests Dashboard May 10, 2024
@Den4ik
Copy link
Contributor

Den4ik commented May 10, 2024

@magento run WebAPI Tests

@engcom-Bravo engcom-Bravo self-assigned this May 13, 2024
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

Assignees

@Den4ik Den4ik

@engcom-Bravo engcom-Bravo

Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: testing in progress
Projects
Pull Requests Dashboard
  
Testing in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Sales Rules regression in 2.4.7
3 participants
@Nuranto @Den4ik @engcom-Bravo