Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update success message on admin backend with field changed ref #38696

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

Franciscof-Serfe
Copy link
Contributor

Description (*)

In relation to this issue #38352, it was detected that the admin user when modifying some field of his account and recording it, the message he received was generic (You saved the account).

For this reason, through this PR we add the information of the modified field(s) to the success message.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes admin Password update. #38352

Manual testing scenarios (*)

  1. Backend -> account setting
  2. modify 1 field and save.
  3. modify 2 fields and save.
  4. modify x fields and save.
  5. Verify that all fields can be modified

Attached video of the tests
successMessage.webm

image
image
image

Questions or comments

FYI: Redirecting to the main dashboard was considered but since the user can decide to generate other modifications after modifying the password, that feature was rejected.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented May 4, 2024

Hi @Franciscof-Serfe. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 4, 2024
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard May 4, 2024
@Franciscof-Serfe
Copy link
Contributor Author

@magento I'm working on it

@Franciscof-Serfe
Copy link
Contributor Author

@magento run all tests

@Franciscof-Serfe
Copy link
Contributor Author

@magento run Static Tests
@magento give me test instance

Copy link

Hi @Franciscof-Serfe. Thank you for your request. I'm working on Magento instance for you.

Copy link

@Den4ik
Copy link
Contributor

Den4ik commented May 10, 2024

@magento give me 2.4-develop instance

Copy link

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review
Projects
Pull Requests Dashboard
  
Review in Progress
Development

Successfully merging this pull request may close these issues.

admin Password update.
2 participants