Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed cursorless echo after input finished #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

richardmcsong
Copy link

Fixes #117

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #118 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage    30.5%   30.41%   -0.09%     
==========================================
  Files           6        6              
  Lines         695      697       +2     
==========================================
  Hits          212      212              
- Misses        462      464       +2     
  Partials       21       21
Impacted Files Coverage Δ
prompt.go 0% <0%> (ø) ⬆️
cursor.go 53.27% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748542e...7e597de. Read the comment docs.

@jrkt
Copy link

jrkt commented Mar 26, 2020

What's the hold up on this PR? This is the one thing holding us up from implementing this library.

jamesdobson added a commit to jamesdobson/promptui that referenced this pull request Apr 18, 2020
Based on: manifoldco#118 by github.com/richardmcsong,
taking only the changes required to fix issue manifoldco#117.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt resource doesn't remove cursor when ENTER key is pressed.
3 participants