-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag for reading ids from geojson source #4228
base: master
Are you sure you want to change the base?
Conversation
hi @artemp - any chance I can get a review for this one? |
@montzkie18 - Yes, I'll find time asap. Thanks for your contribution! |
@montzkie18 - Could you check test data is updated, I'm getting
thanks. |
Hi @artemp - thanks for looking into this.
The updated test data is pushed to this PR: mapnik/test-data#23 EDIT: nvm, I pushed the submodule changes here with the correct git hash |
Codecov Report
@@ Coverage Diff @@
## master #4228 +/- ##
=======================================
Coverage 71.86% 71.86%
=======================================
Files 446 446
Lines 23271 23272 +1
=======================================
+ Hits 16723 16724 +1
Misses 6548 6548
Continue to review full report at Codecov.
|
GeoJSON: Expose
use_id_from_source
datasource parameter to load features with their original ids from the source. Should address #4227Things to note here:
Feature.id
. But once the flag is set, it will throw an error for invalid ids (e.g. string, null, etc...)feature.use_id_from_source()
to check which grammar to use. I figured it can also be used by other plugins if they want to make it as an option.Feature.id
s as unique internally.Depends on this PR: mapnik/test-data#23