Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update README.md about proguard #45

Merged
merged 6 commits into from
May 18, 2024

Conversation

idrakimuhamad
Copy link
Contributor

@idrakimuhamad idrakimuhamad commented May 17, 2024

Building on Android with proguard enabled will require this rule to avoid crashing on release app.

Updating the readme to include this.

Relate to #44 and #42

README.md Outdated Show resolved Hide resolved
@hannojg
Copy link
Member

hannojg commented May 17, 2024

Thanks for the update, however thats not what I meant. I want to keep the installation section at the top short - thus I don't want to move the whole block there.

Can you please put the block back at the bottom where it was initially and just add a one liner like I suggested to the installation section? Thanks!

@idrakimuhamad
Copy link
Contributor Author

Gotcha. I've amended.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@hannojg hannojg merged commit ed31fa2 into margelo:main May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants