fix: isolate modules in module watcher #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't share the same ModuleFinder object -- run_script mutates finder.modules instead of replacing it. Also improve robustness of finder in face of modules that fail to load. Additionally, re-analyze modules when they change.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
approved these changes
May 11, 2024
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.5.3-dev3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ModuleDependencyFinderclass delegates work to the built-in finder and maintains its own cache.Turns out we can't share the same
ModuleFinderobject --run_scriptmutates finder.modules instead of replacing it, which can lead to false positives when detecting which cells change.Also improve robustness of the module watcher in face of modules that fail to be analyzed — we can at least check if the module itself was changed, even if we can't introspect its dependencies.
Additionally, re-analyze modules when they are changed.