Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(attr-tags): naive rendering, no conditionals #2228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LuLaValva
Copy link
Member

Description

  • Very basic attr tag implementation, no conditionals or anything.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@LuLaValva LuLaValva self-assigned this May 14, 2024
Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: b33434a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.32%. Comparing base (5c59829) to head (b33434a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2228   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         332      332           
  Lines       32494    32522   +28     
  Branches     1649     1646    -3     
=======================================
+ Hits        28374    28400   +26     
- Misses       4105     4107    +2     
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant