Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Marko 6) Ensure functions close over scope, integrate serializer updates #2229

Merged
merged 3 commits into from
May 16, 2024

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: 9d12e58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 98.45815% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 87.64%. Comparing base (1f3db3b) to head (9d12e58).

Files Patch % Lines
packages/runtime-tags/src/html/serializer.ts 99.11% 11 Missing ⚠️
packages/runtime-tags/src/dom/resume.ts 74.28% 9 Missing ⚠️
packages/runtime-tags/src/html/writer.ts 98.18% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2229      +/-   ##
==========================================
+ Coverage   87.32%   87.64%   +0.31%     
==========================================
  Files         332      332              
  Lines       32516    33434     +918     
  Branches     1649     1784     +135     
==========================================
+ Hits        28394    29302     +908     
- Misses       4107     4118      +11     
+ Partials       15       14       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey force-pushed the bound-functions branch 2 times, most recently from 02324d5 to e116f44 Compare May 15, 2024 03:36
@DylanPiercey DylanPiercey merged commit 9d94b0d into main May 16, 2024
9 checks passed
@DylanPiercey DylanPiercey deleted the bound-functions branch May 16, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant