Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements accessor for categorical types #3360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implements accessor for categorical types #3360

wants to merge 1 commit into from

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented Sep 25, 2023 •
edited

What do these changes do?

Implements Series.cat accessor for categorical type.

Related issue number

Fixes #1122

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi requested a review from a team as a code owner September 25, 2023 08:53
@wjsi wjsi added this to In progress in DataFrame via automation Sep 25, 2023
@wjsi wjsi changed the title Implements accessor for catrgorical types Implements accessor for categorical types Sep 25, 2023
@wjsi wjsi force-pushed the feature/ordered_accessories branch 3 times, most recently from c6b1725 to 21fdd11 Compare September 25, 2023 09:01
@wjsi wjsi force-pushed the feature/ordered_accessories branch from 21fdd11 to 78d5615 Compare September 27, 2023 08:21
@zhongchun
Copy link
Contributor

zhongchun commented Oct 24, 2023 •
edited

LGTM. We'd better to fix the failed tests, like mars-project.mars and mars-project.mars (CI DataFrame).

@wjsi wjsi force-pushed the feature/ordered_accessories branch from 78d5615 to ce27406 Compare November 2, 2023 03:19
@wjsi wjsi force-pushed the feature/ordered_accessories branch from ce27406 to fd6a0f1 Compare November 2, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpai ericpai ericpai approved these changes

@zhongchun zhongchun Awaiting requested review from zhongchun

@chaokunyang chaokunyang Awaiting requested review from chaokunyang

@wubiliang wubiliang Awaiting requested review from wubiliang

At least 2 approving reviews are required to merge this pull request.

Assignees

@zhongchun zhongchun

@chaokunyang chaokunyang

@wubiliang wubiliang

Labels
mod: dataframe type: feature New feature
Projects
DataFrame
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Series.cat accessor
5 participants
@wjsi @zhongchun @ericpai @chaokunyang @wubiliang