Use ESLint to replace double quotes #30107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
commented
Apr 28, 2024
| @@ -155,7 +155,7 @@ export default class Card extends PureComponent { | |||
| }; | |||
|
|
|||
| if (largeImage && card.get('type') === 'video') { | |||
| thumbnailStyle.aspectRatio = `16 / 9`; | |||
| thumbnailStyle.aspectRatio = '16 / 9'; | |||
There was a problem hiding this comment.
Potentially could skip these too, with the allowTemplateLiterals
|
@renchap this might conflict with some of your conversion PRs, since they reminded me of this :) |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
nschonni
force-pushed
the
js-single-quote
branch
from
c6320ed
to
fa20f86
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought this might be easier since the Prettier way makes many more changes.
Ran
npx eslint --fix --rule 'quotes: [error, "single", {"avoidEscape": true}]' "**/*.jsx"andnpx eslint --fix --rule 'quotes: [error, "single", {"avoidEscape": true}]' "**/*.js"to just fix the quotes that aren't used to avoid escaping