Remove usage of assigns in controller specs
#30195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
added
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #30144 - this is the first half of an attempt to get rid of the
rails-controller-testinggem (restores the deprecatedassignsandassert_templatetest features) usage in advance of moving some things out of controller specs and into system specs.The bulk of the changes here are moving the assertion to about the response body instead of the assigns. For almost all of them there was an obvious way to do this, and I only needed one change to non-spec code (Added dom_id once). There were a few
be_instance_ofchecks that I just removed w/out replacement since there's not an obvious way to do that check w/out assigns, but I'm not sure its particulary useful in the first place.Can split this up if necessary; and will do a follow-up for assert_template, although that one is more substantial I think.