Add icon field to instance endpoint
#30205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
reviewed
May 7, 2024
|
This pull request has merge conflicts that must be resolved before it can be merged. |
renchap
force-pushed
the
icon-api-instance
branch
from
1c5880e
to
552d168
Compare
|
Updated to use the presenter from #30259 so the cache is used for the icons |
Gargron
previously approved these changes
May 19, 2024
Gargron
reviewed
May 19, 2024
| src = URI.join(root_url, src).to_s if src.present? | ||
|
|
||
| { | ||
| src: src || frontend_asset_url("icons/android-chrome-#{size}x#{size}.png"), |
There was a problem hiding this comment.
Would it make sense to make this output consistent with the thumbnail property?
There was a problem hiding this comment.
We can, but there would be no blurhash, and what should the keys be? The thumbnail uses @1x, @2x but I dont think it makes sense for the icons. Should we use size?
|
This pull request has resolved merge conflicts and is ready for review. |
As we now allow admins to customize their app icon, it may be useful to expose it so apps can use it in the UI. This is using the Android icons as they provide a good range of sizes.
renchap
force-pushed
the
icon-api-instance
branch
from
82c37c9
to
18bb0fa
Compare
renchap
force-pushed
the
icon-api-instance
branch
from
18bb0fa
to
4146080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we now allow admins to customize their app icon, it may be useful to expose it so apps can use it in the UI.
This is using the Android icons as they provide a good range of sizes.