Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cache_* methods to preload_* in controller concern #30209

Merged
merged 3 commits into from May 16, 2024

Conversation

mjankowski
Copy link
Contributor

Handles a cleanup TODO left after #29862

The caching aspect of these methods was previously removed, and they are now only passing the collection through the preload process.

  • Updated the two core methods with new prefixes, and all areas where they were used
  • In areas where that usage was wrapped by a similarly mis-named method, also updated the wrapping method
  • Moved the newly-renamed preload-specific methods out to their own concern -- so that the CacheConcern really is just methods helping with caching the PreloadConcern is these two methods doing preloading in controllers. Updated application controller to include this concern

@ClearlyClaire ClearlyClaire added this pull request to the merge queue May 16, 2024
Merged via the queue into mastodon:main with commit 65e8221 May 16, 2024
29 checks passed
@mjankowski mjankowski deleted the rename-cache-to-preload branch May 16, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants