Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active animation to header settings button #30221

Merged

Conversation

daudix
Copy link
Contributor

@daudix daudix commented May 8, 2024

Currently toggling the settings button in header only changes the color which feels a bit boring, subtle animation makes it more fun.

Screencast.from.2024-05-08.21-53-58.webm

Similar animation is already present in the search box so it's not a new concept.

Screencast.from.2024-05-08.21-55-07.webm

Gargron
Gargron previously approved these changes May 8, 2024
ClearlyClaire
ClearlyClaire previously approved these changes May 10, 2024
@ClearlyClaire ClearlyClaire dismissed their stale review May 10, 2024 09:22

Missed something

Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but shouldn't it only be enabled when no-reduce-motion is used?

@daudix
Copy link
Contributor Author

daudix commented May 10, 2024

Fair, although it seems like other such animations (e.g post interactions) don't respect this preference

@daudix
Copy link
Contributor Author

daudix commented May 10, 2024

Perhaps we could simply add the following to make sure all transitions are disabled:

@media (prefers-reduced-motion) {
  *,
  *::before,
  *::after {
    animation: none !important;
    transition: none !important;
  }
}

ClearlyClaire
ClearlyClaire previously approved these changes May 10, 2024
@renchap
Copy link
Sponsor Member

renchap commented May 10, 2024

Can you fix the formatting so the checks pass? yarn fix should do it.

@daudix
Copy link
Contributor Author

daudix commented May 11, 2024

Unfortunately I couldn't setup local dev env to fix this since docker setup fails at the second step (#27398), GitHub Codespaces method doesn't work as well

Edit: After applying #26921 mentioned in the issue above as a git patch there's a different issue: #30213

@daudix
Copy link
Contributor Author

daudix commented May 11, 2024

yarn fix doesn't make any changes compared to the current state

@nschonni
Copy link
Contributor

Try yarn format instead, as that will run Prettier

@ClearlyClaire ClearlyClaire added this pull request to the merge queue May 13, 2024
Merged via the queue into mastodon:main with commit cb93c1e May 13, 2024
27 checks passed
@BrunoFenzl
Copy link

@daudix Did you manage to fix the issue described in #30213?

@daudix daudix deleted the header-settings-button-active-state branch May 14, 2024 18:29
@daudix
Copy link
Contributor Author

daudix commented May 14, 2024

@BrunoFenzl Sadly no :/

daudix added a commit to daudix/mastodon that referenced this pull request May 15, 2024
ClearlyClaire pushed a commit to ClearlyClaire/mastodon that referenced this pull request May 16, 2024
Port 94493cf to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants