-
-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use globalStorageUri for user settings #1295
base: main
Are you sure you want to change the base?
use globalStorageUri for user settings #1295
Conversation
on NixOS I already submitted a patch for this: NixOS/nixpkgs@a00e878 |
Hi @Stunkymonkey thanks for the PR. I think it would be good to check if the old one is present and if so switch the location to the new one, and the check can be removed when we release a major version. cc @equinusocio |
@LasaleFamine I have no development setup locally, so I am coding blind... without testing it. Be warned. So I added some more to check for the old file and if existent use it, else use the new one. Is this what you had in mind? PS: there might be |
@Stunkymonkey actually in this way we are considering the old file as something to use still. If the objective is to migrate to the new use config location, we should copy the old file if present in the new location. |
@LasaleFamine so you prefer this new solution? Or do you want a combination of both? |
@Stunkymonkey thanks for the change. This feels to me the correct way to change the config file. Did you have the possibility to test it? |
Sadly no. I do not even have |
Please setup the whole environment to work and debug this extension. There are many typescript errors. |
6462966
to
6aed5d0
Compare
fix for #1294
this might be a breaking change!?