Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf/arc slice polys #42

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

perf/arc slice polys #42

wants to merge 3 commits into from

Conversation

Oppen
Copy link

@Oppen Oppen commented Apr 26, 2024

  • perf(experimental): use EcoVec for Polynomials
  • Hack around uninit
  • outer shouldn't be ecow and some clones shouldn't be owned
  • add sanitization
  • more sanitization
  • more sanitization
  • more sanitization
  • more sanitization
  • more sanitization
  • try to force unique
  • unsanitize
  • unsanitize
  • perf: use Arc<[P]> for Polynomial

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@Oppen
Revert "fix modulus - 0 case"
f53381c 
This reverts commit 1998807.

Temporarily revert for testing, since this ensures I'm based on what era
is running.
@Oppen
Manual clone
22811fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Oppen