New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EraVM][ELF] Handle emission of NULL pointer explicitly #530
Conversation
Benchmark results:
|
6354a33
to
b85110e
Compare
b85110e
to
a28cc70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Commit message
in MCStreamer::emitIntValue(uint64_t, unsigned int).
->
in MCStreamer::emitIntValue(uint64_t, unsigned int)
.
@akiramenai Do you mean enclosing the text in backticks? If so, I will do it via GitHub UI during merge not to re-trigger the CI. Thanks! |
Make EraVMAsmPrinter handle ConstantPointerNull value by explicitly emitting an equivalent of `.cell 0`, otherwise the generic code would try to emit 256-bit wide zero integer triggering an assertion Assertion `1 <= Size && Size <= 8 && "Invalid size"' failed. in `MCStreamer::emitIntValue(uint64_t, unsigned int)`.
a28cc70
to
7e335a0
Compare
Well, looks like for some reason I cannot edit commit message as part of "rebase and merge". |
Make EraVMAsmPrinter handle ConstantPointerNull value by explicitly emitting an equivalent of
.cell 0
, otherwise the generic code would try to emit 256-bit wide zero integer triggering an assertionin
MCStreamer::emitIntValue(uint64_t, unsigned int)
.