ci: unify workflows with common era-compiler-ci repository #537

antonbaliasnikov · 2024-05-13T13:54:13Z

Code Review Checklist

Purpose

Secrets scanner is now called from https://github.com/matter-labs/era-compiler-ci repository
build-llvm and setup-msys actions are now called from https://github.com/matter-labs/era-compiler-ci repository
Integration tests and benchmarks are now common and called from https://github.com/matter-labs/era-compiler-ci repository
Fixed issues with PR testing that were not rebased from main, removed unnecessary merge-base logic - simplified and optimized checkout part
Fixed issue with compiler cache overriding
Special opt and llc regression tests are moved to the cmake level to fix CPR-1662
Removed release workflow from upstream that we don't use

Thorough testing is here.

Ticket Number

Related to CPR-1691

github-actions · 2024-05-13T17:10:04Z

Benchmark results:

╔═╡ Size (-%) ╞════════════════╡ All M3B3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞══════════════╡ All M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞════════════════╡ All M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞════════════════╡ All MzB3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞══════════════╡ All MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞════════════════╡ All MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════╡ EVMInterpreter M3B3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞═══╡ EVMInterpreter M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞═════╡ EVMInterpreter M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs/gas ╞══════╡ EVMInterpreter M3B3 ╞═╣
║ ADD                                67.667 ║
║ MUL                                39.400 ║
║ SUB                                67.667 ║
║ DIV                                47.800 ║
║ SDIV                               64.600 ║
║ MOD                                46.600 ║
║ SMOD                               62.200 ║
║ ADDMOD                             39.000 ║
║ MULMOD                             36.000 ║
║ EXP                                 9.283 ║
║ SIGNEXTEND                         45.400 ║
║ LT                                 71.667 ║
║ GT                                 71.667 ║
║ SLT                                95.667 ║
║ SGT                                93.667 ║
║ EQ                                 71.667 ║
║ ISZERO                             63.333 ║
║ AND                                65.667 ║
║ OR                                 67.667 ║
║ XOR                                67.667 ║
║ NOT                                59.333 ║
║ BYTE                               75.667 ║
║ SHL                                73.667 ║
║ SHR                                71.667 ║
║ SAR                                89.667 ║
║ SGT                                93.667 ║
║ SHA3                               27.139 ║
║ ADDRESS                            91.000 ║
║ BALANCE                            73.180 ║
║ ORIGIN                           2852.000 ║
║ CALLER                             91.000 ║
║ CALLVALUE                          91.000 ║
║ CALLDATALOAD                       61.667 ║
║ CALLDATASIZE                       91.500 ║
║ CALLDATACOPY                       57.889 ║
║ CODESIZE                           88.500 ║
║ CODECOPY                          108.667 ║
║ GASPRICE                         2846.000 ║
║ EXTCODESIZE                         5.149 ║
║ EXTCODECOPY                         4.667 ║
║ RETURNDATASIZE                     89.000 ║
║ RETURNDATACOPY                     55.889 ║
║ EXTCODEHASH                         2.687 ║
║ BLOCKHASH                         244.450 ║
║ COINBASE                         2849.000 ║
║ TIMESTAMP                        2843.000 ║
║ NUMBER                           2843.000 ║
║ PREVRANDAO                       2843.000 ║
║ GASLIMIT                         2849.000 ║
║ CHAINID                          2837.000 ║
║ SELFBALANCE                       640.200 ║
║ BASEFEE                          2840.000 ║
║ POP                                79.000 ║
║ MLOAD                              43.667 ║
║ MSTORE                             44.333 ║
║ MSTORE8                            47.111 ║
║ SLOAD                               5.766 ║
║ SSTORE                              0.621 ║
║ JUMP                               37.333 ║
║ JUMPI                              32.818 ║
║ PC                                 91.500 ║
║ MSIZE                             101.000 ║
║ GAS                                85.500 ║
║ JUMPDEST                          122.000 ║
║ PUSH0                              88.500 ║
║ PUSH1                              75.333 ║
║ PUSH2                              91.667 ║
║ PUSH4                             150.333 ║
║ PUSH5                             170.667 ║
║ PUSH6                             191.000 ║
║ PUSH7                             211.333 ║
║ PUSH8                             231.667 ║
║ PUSH9                             252.000 ║
║ PUSH10                            272.333 ║
║ PUSH11                            290.667 ║
║ PUSH12                            313.000 ║
║ PUSH13                            333.333 ║
║ PUSH14                            343.333 ║
║ PUSH15                            392.667 ║
║ PUSH16                            413.000 ║
║ PUSH17                            433.333 ║
║ PUSH18                            453.667 ║
║ PUSH19                            474.000 ║
║ PUSH20                            494.333 ║
║ PUSH21                            514.667 ║
║ PUSH22                            535.000 ║
║ PUSH23                            555.333 ║
║ PUSH24                            575.667 ║
║ PUSH25                            596.000 ║
║ PUSH26                            616.333 ║
║ PUSH27                            636.667 ║
║ PUSH28                            657.000 ║
║ PUSH29                            677.333 ║
║ PUSH30                            681.333 ║
║ PUSH31                            758.667 ║
║ PUSH32                            779.000 ║
║ DUP1                               61.333 ║
║ DUP2                               65.333 ║
║ DUP3                               65.333 ║
║ DUP4                               65.333 ║
║ DUP5                               65.333 ║
║ DUP6                               65.333 ║
║ DUP7                               65.333 ║
║ DUP8                               65.333 ║
║ DUP9                               65.333 ║
║ DUP10                              65.333 ║
║ DUP11                              65.333 ║
║ DUP12                              65.333 ║
║ DUP13                              63.333 ║
║ DUP14                              65.333 ║
║ DUP15                              65.333 ║
║ DUP16                              65.333 ║
║ SWAP1                              66.000 ║
║ SWAP2                              66.000 ║
║ SWAP3                              66.000 ║
║ SWAP4                              66.000 ║
║ SWAP5                              66.000 ║
║ SWAP6                              66.000 ║
║ SWAP7                              66.000 ║
║ SWAP8                              66.000 ║
║ SWAP9                              66.000 ║
║ SWAP10                             66.000 ║
║ SWAP11                             64.000 ║
║ SWAP12                             66.000 ║
║ SWAP13                             66.000 ║
║ SWAP14                             66.000 ║
║ SWAP15                             66.000 ║
║ SWAP16                             66.000 ║
║ CREATE                              5.046 ║
║ CALL                               56.371 ║
║ RETURN                                inf ║
║ DELEGATECALL                       52.286 ║
║ STATICCALL                         53.248 ║
║ CREATE2                             7.067 ║
║ REVERT                                inf ║
╠═╡ Ergs/gas (-%) ╞═╡ EVMInterpreter M3B3 ╞═╣
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞═════╡ EVMInterpreter MzB3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞═══╡ EVMInterpreter MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞═════╡ EVMInterpreter MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞════════╡ Precompiles M3B3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞══════╡ Precompiles M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞════════╡ Precompiles M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞════════╡ Precompiles MzB3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞══════╡ Precompiles MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞════════╡ Precompiles MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞══════════╡ Real life M3B3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞════════╡ Real life M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞══════════╡ Real life M3B3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

╔═╡ Size (-%) ╞══════════╡ Real life MzB3 ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Cycles (-%) ╞════════╡ Real life MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╠═╡ Ergs (-%) ╞══════════╡ Real life MzB3 ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                               0.000 ║
╚═══════════════════════════════════════════╝

github-actions · 2024-05-16T16:39:00Z

✅ With the latest revision this PR passed the C/C++ code formatter.

antonbaliasnikov · 2024-05-17T12:59:34Z

To properly test, I broke formatting, then fixed it but broke clang-tidy, then I fixed everything:

Here is the workflow run with the test results.

As expected:

Formatting failed for 8476390af2f1a65af351dd9f11c1a72ab6ad76c9
Then linter failed for
526eacfe71279b5e122f57834f454889ee3416e8

And everything else passed as expected.

Additionally this test run was executed on the not rebased version that confirmed that everything is working properly even if rebase did not happen.

llvm/test/CMakeLists.txt

antonbaliasnikov force-pushed the aba-cpr-1691-set-up-a-pipeline-to-apply-all-ci-changes-to-all-repos branch from 434578a to d9812ad Compare May 13, 2024 13:56

antonbaliasnikov force-pushed the aba-cpr-1691-set-up-a-pipeline-to-apply-all-ci-changes-to-all-repos branch from 8848177 to 2b77f70 Compare May 16, 2024 12:47

antonbaliasnikov force-pushed the aba-cpr-1691-set-up-a-pipeline-to-apply-all-ci-changes-to-all-repos branch 11 times, most recently from 826072e to e2fff3a Compare May 17, 2024 11:32

antonbaliasnikov force-pushed the aba-cpr-1691-set-up-a-pipeline-to-apply-all-ci-changes-to-all-repos branch from 41f03a1 to 50ddc84 Compare May 17, 2024 13:09

antonbaliasnikov changed the title ~~[WIP] [DO NOT MERGE] ci: unified workflows~~ ci: unify workflows with common era-compiler-ci repository May 17, 2024

antonbaliasnikov force-pushed the aba-cpr-1691-set-up-a-pipeline-to-apply-all-ci-changes-to-all-repos branch from 50ddc84 to de98702 Compare May 17, 2024 13:14

antonbaliasnikov marked this pull request as ready for review May 17, 2024 14:05

antonbaliasnikov requested review from hedgar2017, akiramenai and FlashSheridan May 17, 2024 14:06

hedgar2017 approved these changes May 17, 2024

View reviewed changes

antonbaliasnikov force-pushed the aba-cpr-1691-set-up-a-pipeline-to-apply-all-ci-changes-to-all-repos branch from de98702 to 52c4bf4 Compare May 20, 2024 08:06

antonbaliasnikov commented May 20, 2024

View reviewed changes

llvm/test/CMakeLists.txt Outdated Show resolved Hide resolved

antonbaliasnikov force-pushed the aba-cpr-1691-set-up-a-pipeline-to-apply-all-ci-changes-to-all-repos branch from 52c4bf4 to f627778 Compare May 20, 2024 09:43

hedgar2017 approved these changes May 20, 2024

View reviewed changes

ci: unify workflows with common era-compiler-ci repository

6f72895

antonbaliasnikov force-pushed the aba-cpr-1691-set-up-a-pipeline-to-apply-all-ci-changes-to-all-repos branch from f627778 to 6f72895 Compare May 20, 2024 16:23

antonbaliasnikov merged commit 1aa7840 into main May 20, 2024
7 of 8 checks passed

antonbaliasnikov deleted the aba-cpr-1691-set-up-a-pipeline-to-apply-all-ci-changes-to-all-repos branch May 20, 2024 17:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: unify workflows with common era-compiler-ci repository #537

ci: unify workflows with common era-compiler-ci repository #537

antonbaliasnikov commented May 13, 2024 •

edited

github-actions bot commented May 13, 2024 •

edited

github-actions bot commented May 16, 2024 •

edited

antonbaliasnikov commented May 17, 2024 •

edited

ci: unify workflows with common era-compiler-ci repository #537

ci: unify workflows with common era-compiler-ci repository #537

Conversation

antonbaliasnikov commented May 13, 2024 • edited

Code Review Checklist

Purpose

Ticket Number

github-actions bot commented May 13, 2024 • edited

github-actions bot commented May 16, 2024 • edited

antonbaliasnikov commented May 17, 2024 • edited

antonbaliasnikov commented May 13, 2024 •

edited

github-actions bot commented May 13, 2024 •

edited

github-actions bot commented May 16, 2024 •

edited

antonbaliasnikov commented May 17, 2024 •

edited