Added comment explaining discrepancy in the field names. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why can't we change it in a backwards compatible way? |
|
Also, is the field name visible only in code? I guess not, it's probably visible in logs too. |
|
we store commitqc in postgres in jsonb format |
|
Ok. But why can't we change the name? |
|
because the commitqc contains a signature which contains this field. Jsonb uses the text names in encoding. |
brunoffranca
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing the crypto keys back from bn254 to bls12_381, we forgot to rename the proto fields as well. It is not feasible to do it now, because of backward compatibility, so I've just added comments to explain the discrepancy.