Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some comments and typo in Mailbox and Executor #393

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fix some comments and typo in Mailbox and Executor #393

wants to merge 3 commits into from

Conversation

JhChoy
Copy link

@JhChoy JhChoy commented Apr 23, 2024 •
edited

What ❔

  1. Fix comments(related to chore: fix some comments in Mailbox and Executor facets #392)
  2. Add internal as a default access prefix to Mailbox.ERA_CHAIN_ID
  3. Fix error msg

Why ❔

  1. For readability
  2. For explicit code expression
  3. It seems different from other error messages using the error code in Executor.sol.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbochok vladbochok Awaiting requested review from vladbochok vladbochok is a code owner

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless StanislavBreadless is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JhChoy