feat: cleaner chain migration, native token vault, general bridging via L1SharedBridge #463
+2,843
−1,479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l1-contracts/contracts/state-transition/chain-deps/facets/Mailbox.sol
Outdated
Show resolved
Hide resolved
…s/era-contracts into kl/sync-layer-reorg
vladbochok
reviewed
May 12, 2024
Raid5594
reviewed
May 13, 2024
| @@ -230,6 +230,7 @@ contract DefaultAccount is IAccount { | |||
| assert(msg.sender != BOOTLOADER_FORMAL_ADDRESS); | |||
|
|
|||
| // If the contract is called directly, behave like an EOA | |||
|
|
|||
There was a problem hiding this comment.
nit: probably line added by mistake or linting
kelemeno
changed the title
Raid5594
reviewed
May 13, 2024
| /// @custom:security-contact security@matterlabs.dev | ||
| /// @dev Vault holding L1 native ETH and ERC20 tokens bridged into the hyperchains. | ||
| /// @dev Designed for use with a proxy for upgradability. | ||
| contract L1NativeTokenVault is |
There was a problem hiding this comment.
I can see that this essentially separates from the shared bridge, but in the diagram we have a separation between native token vault & the standard scenario.
Does this mean we're only considering here the tokens native to L1?
As I understand the vault for L2 native tokens has yet to be added
There was a problem hiding this comment.
Yes, we cannot handle l2 native token yet. ( You could implement it if you want )
Raid5594
reviewed
May 14, 2024
Raid5594
reviewed
May 14, 2024
kelemeno
changed the title
started filling out bridge migration functions
…cts into kl/sync-layer-reorg
…s/era-contracts into kl/sync-layer-reorg
Co-authored-by: Raid Ateir <ra@matterlabs.dev> Co-authored-by: kelemeno <34402761+kelemeno@users.noreply.github.com>
Co-authored-by: kelemeno <kl@matterlabs.dev>
…cts into kl/sync-layer-reorg
…s/era-contracts into kl/sync-layer-reorg
Co-authored-by: Raid Ateir <ra@matterlabs.dev> Co-authored-by: kelemeno <kl@matterlabs.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist