Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow install script in CI #370

Merged
merged 11 commits into from
Jun 4, 2024
Merged

fix: allow install script in CI #370

merged 11 commits into from
Jun 4, 2024

Conversation

nbaztec
Copy link
Collaborator

@nbaztec nbaztec commented May 10, 2024

Motivation

The current install script does not work in CI as source and export PATH are not supported by GHA. Additionally the script does not exit with failure in case of a failed verification.

Solution

  • Detect $CI mode to directly add to both PATH and GITHUB_PATH instead.
  • Exit with error code on verification failure.

@nbaztec nbaztec changed the title check ci: test fix: allow install script in CI May 10, 2024
@nbaztec nbaztec requested a review from dutterbutter May 10, 2024 10:33
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (minor nit, but not blocking)

@nbaztec nbaztec merged commit 35d23b2 into dev Jun 4, 2024
11 checks passed
@nbaztec nbaztec deleted the nish-try-ci branch June 4, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants