New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Prover CLI): requeue
cmd
#1719
base: main
Are you sure you want to change the base?
Conversation
@EmilLuta we can discuss this during the daily, but I think I'm missing a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, so good. As we chatted during daily, let's incorporate changes for the requeuer.
…bs/zksync-era into requeue_witness_generator_jobs
requeue
cmd scaffolding + requeue basic-witness-generator-jobs
cmdrequeue
cmd
…bs/zksync-era into requeue_witness_generator_jobs
I think the spellcheck error is not related to this PR:
|
…bs/zksync-era into requeue_witness_generator_jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a bunch of nits.
…bs/zksync-era into requeue_witness_generator_jobs
…_witness_generator_jobs
…_witness_generator_jobs
What ❔
Adds a
requeue
command that requeues a given batch if it's stuck. It looks at all jobs that are stuck and requeues them. A job is stuck if it has a large number of attempts and is not successful.For now, the attempts are set via a cmd flag (
--max-attempts
) which if not set, is 10 by default.Usage Example
Why ❔
We want to be able to requeue a stuck batch with the CLI.
Checklist
zk fmt
andzk lint
.zk spellcheck
.zk linkcheck
.