Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: zksync-ethers 5.8.0-beta.5 #1763

Draft
wants to merge 628 commits into
base: main
Choose a base branch
from
Draft

chore: zksync-ethers 5.8.0-beta.5 #1763

wants to merge 628 commits into from

Conversation

benceharomi
Copy link
Member

@benceharomi benceharomi commented Apr 22, 2024 •
edited

What ❔

Start using the https://github.com/zksync-sdk/zksync-ethers/releases/tag/v5.8.0-beta.5 release from the SDK, instead of depending a GitHub commit.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

jrchatruc and others added 30 commits March 11, 2024 16:22
@jrchatruc
Merge pull request #1319 from lambdaclass/conversion_rate_component
feaf132 
feat(Gas Oracle): Conversion rate component
@jrchatruc
Merge remote-tracking branch 'upstream/lambdaclass_gas_oracle' into r…
3fff7d9 
…emove-token-fetcher-singleton
@jrchatruc
Merge pull request #1360 from lambdaclass/remove-token-fetcher-singleton
ba7762c 
feat(Gas Oracle): Remove Fetcher singleton
@fkrause98
feat: Handle Web3Error::NotImplemented on EN
f544652
@fkrause98
Merge branch 'kl-factory' into base-token-addr-endpoint
ffa9e11
@jrchatruc
Merge branch 'kl-factory' into lambdaclass_gas_oracle
d81aef0
@ly0va
Fix unit tests
421090f
@ly0va
Tweak CI for kl-factory
1330692
@ly0va
Merge branch 'main' into kl-factory
c246082
@ly0va
post-merge fixes
3afcade
@ly0va
Commitment utils fix
1e22b58
@juan518munoz
fix init and zk test i server
599d318
@benceharomi
Merge pull request #1440 from lambdaclass/kl-factory
35df259 
fix(kl-factory): fix init and zk test i server
@fkrause98
Merge branch 'kl-factory' into base-token-addr-endpoint
cb6b373
@fkrause98
feat: Handle Web3Error::NotImplemented after merge
28f6523
@fkrause98
fix: update protobuf config
9cd48b7
@juan518munoz
zk fmt
5680df8
@juan518munoz
Merge remote-tracking branch 'matter-labs/kl-factory' into gas-oracle
47c444f
update package.json
df9664c
@juan518munoz
initial commit
3baab56
@juan518munoz
zk fmt
b6baace
@juan518munoz
fix test
aa868fb
@juan518munoz
rename native token to base token
b520744
@juan518munoz
fix env load
29289c9
@ly0va
Merge pull request #1479 from lambdaclass/kl-factory-integration-test…
53aa529 
…s/custom-accounts

fix(kl-factory/integration-tests): custom accounts
add gas oracle documentation
7c8ec45
fmt
2a7761d
@fkrause98
Merge branch 'kl-factory' into gas-oracle
55ae89f
@ly0va
Merge pull request #1481 from lambdaclass/kl-factory-fix-contracts-tests
911e1de 
fix(kl-factory): fix contracts tests
@ly0va
Update yarn.lock
cef5baa
@benceharomi benceharomi changed the title chore: zksync-ethers 5.8.0-beta.4 chore: zksync-ethers 5.8.0-beta.5 Apr 24, 2024
@benceharomi benceharomi marked this pull request as ready for review April 24, 2024 18:04
@mm-zk
Copy link
Collaborator

mm-zk commented Apr 25, 2024

LGTM - but please revert the change in contracts (the code should work without it, right?)

@benceharomi benceharomi marked this pull request as draft May 8, 2024 12:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

No performance difference detected (anymore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless

@mm-zk mm-zk Awaiting requested review from mm-zk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet