chore(validium): fix validium init and server #1796
Merged
+229
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koloz193
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet and
otani88
ilitteri
reviewed
Apr 26, 2024
There was a problem hiding this comment.
The PR looks good in general. Left some comments with suggestions, nits, and spotted some errors, and questions.
I'm trying to run this locally like this
zk && zk clean --all && zk env dev_validium && zk init --validium mode
and I'm having these errors:
zk init
- While running the server in genesis (the same errors is in the CI)
Error: Failed to save SetChainId upgrade transaction Caused by: Expected a single set_chain_id event, got these 0: [] - Error: TypeError: diamondProxy.setValidiumMode is not a function
server
We can't operate after tx fail -> revert_reason: "revert: pl"
I think that the server error is due to the error 2 I'm having during the init
core/lib/l1_contract_interface/src/i_executor/structures/commit_batch_info.rs
Outdated
Show resolved
Hide resolved
Update:
|
…rator-layer chore(node): remove is_validium flag and make it more extensible
popzxc
reviewed
May 1, 2024
StanislavBreadless
previously approved these changes
May 1, 2024
popzxc
previously approved these changes
May 3, 2024
…oss_check fix(Validium): `getPubdataPricingMode` contract call
kelemeno
approved these changes
May 3, 2024
StanislavBreadless
approved these changes
May 6, 2024
popzxc
approved these changes
May 6, 2024
hatemosphere
approved these changes
May 6, 2024
otani88
approved these changes
May 6, 2024
Deniallugo
pushed a commit
that referenced
this pull request
May 7, 2024
## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. - [ ] Linkcheck has been run via `zk linkcheck`. --------- Co-authored-by: ilitteri <ilitteri@fi.uba.ar>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.