Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Extract genesis into separate crate #1797

Merged
merged 9 commits into from May 6, 2024

Conversation

AnastasiiaVashchuk
Copy link
Contributor

@AnastasiiaVashchuk AnastasiiaVashchuk commented Apr 25, 2024

What ❔

Extract utilities needed to perform genesis into a dedicated crate.

Why ❔

Part of splitting zksync_core into a set of crates.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@AnastasiiaVashchuk AnastasiiaVashchuk changed the title feat(node): Construct shared mods crate in new node dirictory feat(node): Construct shared mods crate in new node directory Apr 25, 2024
Cargo.toml Outdated Show resolved Hide resolved
core/node/shared/src/genesis.rs Outdated Show resolved Hide resolved
core/node/shared/src/genesis.rs Outdated Show resolved Hide resolved
@AnastasiiaVashchuk
Copy link
Contributor Author

AnastasiiaVashchuk commented Apr 29, 2024

Key moments for this point in time:

  • zlsync_core/genesis.rs content is chunked into 3 logical modules now: utils.rs, tests.rs, and mod.rs in node/shared/genesis
  • Important - changed the way of getting storage_logs needed for initializing ZkSyncTree in genesis mod.

@popzxc popzxc changed the title feat(node): Construct shared mods crate in new node directory feat(node): Extract genesis into separate crate May 3, 2024
Cargo.toml Show resolved Hide resolved
@popzxc popzxc requested a review from Deniallugo May 3, 2024 09:56
@popzxc popzxc marked this pull request as ready for review May 3, 2024 09:56
Deniallugo
Deniallugo previously approved these changes May 6, 2024
Copy link
Contributor

@Deniallugo Deniallugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run
zk run genesis-config-generator --check
if it's not failing i'm ok with this change

@popzxc popzxc added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@popzxc popzxc added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@popzxc popzxc added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@popzxc popzxc added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit a8c4599 May 6, 2024
36 checks passed
@popzxc popzxc deleted the anastasiia-construct-shared-mods-crate branch May 6, 2024 13:22
Deniallugo pushed a commit that referenced this pull request May 7, 2024
## What ❔

Extract utilities needed to perform genesis into a dedicated crate.

## Why ❔

Part of splitting `zksync_core` into a set of crates.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
- [ ] Spellcheck has been run via `zk spellcheck`.
- [ ] Linkcheck has been run via `zk linkcheck`.

---------

Co-authored-by: Igor Aleksanov <popzxc@yandex.ru>
RomanBrodetski pushed a commit that referenced this pull request May 8, 2024
🤖 I have created a release *beep* *boop*
---


##
[24.1.0](core-v24.0.0...core-v24.1.0)
(2024-05-08)


### Features

* add `sendRawTransactionWithDetailedOutput` API
([#1806](#1806))
([6a30a31](6a30a31))
* add getGasPerPubdataByte endpoint
([#1778](#1778))
([d62dd08](d62dd08))
* **config:** Wrap sensitive urls
([#1828](#1828))
([c8ee740](c8ee740))
* **db:** Implement weak references to RocksDB
([e0d4daa](e0d4daa))
* **en:** Add pruning health checks and rework pruning config
([#1790](#1790))
([e0d4daa](e0d4daa))
* Extract proof_data_handler into separate crate
([#1677](#1677))
([f4facee](f4facee))
* Extract several crates from zksync_core
([#1859](#1859))
([7dcf796](7dcf796))
* **node:** Extract genesis into separate crate
([#1797](#1797))
([a8c4599](a8c4599))
* **Prover CLI:** `status batch` command
([#1638](#1638))
([3fd6d65](3fd6d65))
* prover components versioning
([#1660](#1660))
([29a4ffc](29a4ffc))
* Update provers current version
([#1872](#1872))
([bb5f129](bb5f129))


### Bug Fixes

* **basic_types:** bincode deserialization for `L2ChainId`
([#1835](#1835))
([fde85f4](fde85f4))
* **contract-verifier:** YUL system-mode verification
([#1863](#1863))
([5aa7d41](5aa7d41))
* **loadtest:** Do not initiate transactions with 0 amount
([#1847](#1847))
([1bbe108](1bbe108))


### Performance Improvements

* **db:** Fine-tune state keeper cache performance / RAM usage
([#1804](#1804))
([82bf40e](82bf40e))
* **state-keeper:** Improve `FilterWrittenSlots` l1 batch seal stage
([#1854](#1854))
([4cf235f](4cf235f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: perekopskiy <mikeson.dp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants