chore: remove storage_logs field from ExecutionState #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect that compiling prover will fail but let's see. |
|
CI for prover was skipped, so prover doesn't depend on multivm. In that case this change shouldn't cause any problems. |
perekopskiy
approved these changes
Apr 29, 2024
|
@joonazan we need storage logs for each L2 block (deduplicated too but within each L2 block), is new VM capable of producing those? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Deniallugo
pushed a commit
that referenced
this pull request
May 7, 2024
Before this change CurrentExecutionState contained deduplicated storage logs and the raw storage logs. However, the fast VM cannot produce the raw storage logs, as those are an implementation detail. Luckily it seems that they aren't needed, at least for out-of-circuit use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change CurrentExecutionState contained deduplicated storage logs and the raw storage logs. However, the fast VM cannot produce the raw storage logs, as those are an implementation detail. Luckily it seems that they aren't needed, at least for out-of-circuit use.