Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Prover CLI): delete cmd #1802

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

feat(Prover CLI): delete cmd #1802

wants to merge 37 commits into from
+497 −1

Conversation

ilitteri
Copy link
Member

@ilitteri ilitteri commented Apr 25, 2024 •
edited

What ❔

Adds command delete to the Prover CLI. This command is used for:

  • Deleting the entire prover DB.
  • Deleting all the data of a given batch.
  • Deleting all the data for all the failed jobs of a given batch.

Why ❔

A prover operator may want to delete data related to some batch or batches, and even all the DB.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@ilitteri ilitteri marked this pull request as ready for review April 30, 2024 18:33
EmilLuta
EmilLuta reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Left a bunch of nits.

EmilLuta
EmilLuta previously approved these changes May 3, 2024
View reviewed changes
@EmilLuta EmilLuta added this pull request to the merge queue May 3, 2024
@EmilLuta EmilLuta removed this pull request from the merge queue due to a manual request May 3, 2024
@EmilLuta
Copy link
Contributor

EmilLuta commented May 3, 2024

I believe a bunch of things will conflict with the newly added PRs. 1 last rebase (after merge) and we're good to merge.

@ilitteri ilitteri requested a review from EmilLuta May 3, 2024 13:22
@ilitteri ilitteri requested a review from EmilLuta May 6, 2024 16:44
ColoCarletti
ColoCarletti previously approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@ColoCarletti ColoCarletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColoCarletti ColoCarletti ColoCarletti left review comments

@Artemka374 Artemka374 Awaiting requested review from Artemka374

@EmilLuta EmilLuta Awaiting requested review from EmilLuta

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilitteri @EmilLuta @ColoCarletti