Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(state-keeper): Remove pre_insert_txs step #1812

Open
wants to merge 5 commits into
base: parallel-miniblock-seal
Choose a base branch
from
Open

feat(state-keeper): Remove pre_insert_txs step #1812

wants to merge 5 commits into from

Conversation

perekopskiy
Copy link
Contributor

@perekopskiy perekopskiy commented Apr 26, 2024 •
edited

What ❔

Removes pre_insert_txs l2 block seal step. Instead insert_txs flag should be passed to mark_txs_as_executed_in_l2_block.

Why ❔

Inserting txs with block data right away is faster then insert + updating block data.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@perekopskiy perekopskiy marked this pull request as ready for review April 29, 2024 13:50
RomanBrodetski
RomanBrodetski approved these changes Apr 30, 2024
View reviewed changes
core/lib/dal/src/transactions_dal.rs Show resolved Hide resolved
core/lib/dal/src/transactions_dal.rs Show resolved Hide resolved
core/lib/dal/src/transactions_dal.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slowli slowli slowli left review comments

@RomanBrodetski RomanBrodetski RomanBrodetski approved these changes

@itegulov itegulov Awaiting requested review from itegulov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@perekopskiy @RomanBrodetski @slowli