Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) feat(chore): zkSync node public release #1059

Merged
merged 5 commits into from May 13, 2024
Merged

Conversation

githubdoramon
Copy link
Collaborator

What πŸ’»

  • Renames External Node to zkSync node
  • Adds doc changes of new features

Why βœ‹

  • To improve clarity on what the node is (just a full node, no need to call it external)
  • Improve docs on the new features/configs/ways of running

@githubdoramon githubdoramon requested review from a team as code owners May 7, 2024 13:48
Copy link

github-actions bot commented May 7, 2024

Visit the preview URL for this PR (updated for commit 688a936):

https://staging-zksync-web-era-docs--pr1059-feat-20240507-node-rvpz3yci.web.app

(expires Mon, 20 May 2024 16:34:03 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: f408c7165e11221d785cc3915b60f2a4a4f277f9

@dutterbutter
Copy link
Contributor

@githubdoramon are you then adding the quickstart guide or is there still a need for me to do so?

@githubdoramon
Copy link
Collaborator Author

@dutterbutter I left the PR for Ago and Alex O to work on and do any additional changes. If you also have the context, please feel free to work on it :)

@agolajko
Copy link
Contributor

agolajko commented May 8, 2024

@dutterbutter please add the guide! https://github.com/matter-labs/zksync-era/blob/main/docs/guides/external-node/00_quick_start.md

Nothing to add apart from that, ready to push this to be public on the week of 13 May

@dutterbutter
Copy link
Contributor

@agolajko added here: #1063

@dutterbutter
Copy link
Contributor

@agolajko you need to add Gbps to the spelling dictionary here: https://github.com/matter-labs/zksync-web-era-docs/blob/main/cspell-zksync.txt

dutterbutter
dutterbutter previously approved these changes May 13, 2024
@dutterbutter dutterbutter merged commit 34c6c79 into main May 13, 2024
7 checks passed
@dutterbutter dutterbutter deleted the feat/20240507_node branch May 13, 2024 16:37
Copy link

πŸŽ‰ This PR is included in version 1.48.3 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants