Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add tx filterer docs, fix minor mistakes #996

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dimazhornyk
Copy link
Contributor

@dimazhornyk dimazhornyk commented Mar 27, 2024

What 💻

  • add tx filterer docs
  • fix minor style mistakes/typos

Why ✋

  • cover new feature with lacking docs

@dimazhornyk dimazhornyk requested review from a team as code owners March 27, 2024 16:34
Copy link

github-actions bot commented Mar 27, 2024

Visit the preview URL for this PR (updated for commit f917710):

https://staging-zksync-web-era-docs--pr996-add-tx-filterer-doc-c6pcuobu.web.app

(expires Thu, 16 May 2024 13:05:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f408c7165e11221d785cc3915b60f2a4a4f277f9

docs/build/developer-reference/l1-l2-interop.md Outdated Show resolved Hide resolved
docs/zk-stack/components/zkEVM/bootloader.md Outdated Show resolved Hide resolved
docs/build/developer-reference/l1-l2-interop.md Outdated Show resolved Hide resolved
docs/build/developer-reference/l1-l2-interop.md Outdated Show resolved Hide resolved
docs/build/developer-reference/l1-l2-interop.md Outdated Show resolved Hide resolved

A hyperchain operator can filter L1→L2 transactions coming through the Diamond proxy. It is achieved by having an
address of the special contract, responsible for transaction filtering, in the state transition storage. If the filterer
exists, it is being called in the [Mailbox facet](https://github.com/matter-labs/era-contracts/blob/dev/l1-contracts/contracts/state-transition/chain-deps/facets/Mailbox.sol#L243)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links are for the dev branch. As these are not live, do we want to hold off on merging these changes until 1.5.0 is live?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it makes sense to wait for 1.5.0 before merging. I'll keep track of it and ping you when it's ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants