refactor: keycloak PR remaining TODOs #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
reviewed
May 13, 2024
api/utils.go
Outdated
| // user represents a user in the users.txt file | ||
| // The format of each line in the file is: | ||
| // (authentication_type:)?email password | ||
| func parseUserFromLine(u user) (username, email, password, authenticationType string) { |
There was a problem hiding this comment.
The more I look at this the more I am wondering whether this logic should be part of getUserCredentials. Would that make sense or are there further complexities?
agnivade
approved these changes
May 15, 2024
|
|
||
| switch ue.config.AuthenticationType { | ||
| case AuthenticationTypeOpenID: | ||
| if err := ue.authOpenID(authOpenIDLogin); err != nil { | ||
| return fmt.Errorf("error while logging in using OpenID: %w", err) | ||
| } | ||
|
|
||
| loggedUser, _, err = ue.client.GetUserByUsername(context.Background(), user.Username, "") |
There was a problem hiding this comment.
Ah okay, so Signup already had the right code. We just hadn't applied it to Login? That feels a bit weird.
There was a problem hiding this comment.
Yeah, in my changes (thinking it wasn't working at that particular time because of a Keycloak issue) I forgot that Login should store the user the same way as SignUp does.
I tested this locally and can confirm that users can login correctly using openID |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
keycloak.envfileLogin/SignUpmethods instead ofauthOpenIDmethod.