Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-57820: Remove Experimental Label from User status away timeout #26928

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

drew9696
Copy link

@drew9696 drew9696 commented Apr 29, 2024

Summary

Moves the "User status away timeout" from the Experimental section of the admin console to the "Users & Teams" page instead.

Ticket Link

Fixes #26775
Jira https://mattermost.atlassian.net/browse/MM-57820

Screenshots

before after
Before After

i18n Working

i18n

Release Note

Moved the User Status Away Timeout setting from Experimental to Users and Teams section.

@mm-cloud-bot
Copy link

@drew9696: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @drew9696,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Moves the "User status away timeout" from the Experimental section
of the admin console to the "Users & Teams" page instead.
@drew9696 drew9696 force-pushed the MM-57820_move-user-status-away branch from 91853a3 to 0a0cf64 Compare April 29, 2024 20:50
@mm-cloud-bot mm-cloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed labels Apr 29, 2024
@hanzei hanzei added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Apr 30, 2024
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts.

@isacikgoz
Copy link
Member

Hey @drew9696 thanks for the contribution! Did you check the failure on CI? The i18n files are managed externally so the only change should be on i18n/en.json. I see you changed the key therefore updated others but you can either leave it as is, or, create a new key without deleting the old one.

@drew9696
Copy link
Author

Hey @isacikgoz sorry for the delay in response. I originally felt like moving all them over would save translators effort trying to re-translate something that already pre-existed, and felt the key was a little deceiving in that it included the experimental piece inside of it.
If it's preferred not to modify any of those other files I think I'll lean on the side of not modifying the key, as it seems like getting the same string translated in all those languages would be more painful than just living with experimental. I'll push up my change and should be good to go afterwards.

Removes all the changes to non-English i18n files, and maintains the existing key with the "experimental" prefix
@isacikgoz
Copy link
Member

/update-branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Contributor release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Experimental label: User status away timeout
5 participants