Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Video Unavailable problem at YouTube preview #26980

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Sn-Kinos
Copy link

@Sn-Kinos Sn-Kinos commented May 9, 2024

Summary

Fixed the problem that YouTube preview shows Video Unavailable instead of the video.

  • Added the properties on the iframe for YouTube preview at youtube_video.tsx

Reproduce

Create a post that occurs Video Unavailable problem. I used https://youtu.be/edsx_MOhVnk on the below screenshots.

Ticket Link

No Tickets. (less than 20 lines of code change)

Screenshots

I haven't change the UI. But I can show about it w/ screenshots.

before after
image image

Release Note

Fixed the problem that YouTube preview shows Video Unavailable instead of the video.

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 9, 2024
@mattermost-build
Copy link
Contributor

Hello @Sn-Kinos,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@pvev
Copy link
Contributor

pvev commented May 9, 2024

hey @Sn-Kinos , thank you for your contribution. Could you please describe the exact steps on how to reproduce the issue you are trying to solve so we can create a ticket and associate it with this fix? Thanks!

@Sn-Kinos
Copy link
Author

hey @Sn-Kinos , thank you for your contribution. Could you please describe the exact steps on how to reproduce the issue you are trying to solve so we can create a ticket and associate it with this fix? Thanks!

Thanks @pvev! I added the reproduce section on the text :D

@Sn-Kinos Sn-Kinos marked this pull request as draft May 14, 2024 04:05
@Sn-Kinos Sn-Kinos marked this pull request as ready for review May 14, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants