Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GetMasterX() to ensure writeability for the RefreshPostStats job #26986

Merged
merged 1 commit into from May 13, 2024
Merged

Use GetMasterX() to ensure writeability for the RefreshPostStats job #26986

merged 1 commit into from May 13, 2024

Conversation

devinbinnie
Copy link
Member

Summary

We noticed errors on the RefreshPostStats job where we had read-only transaction, where we need to guarantee a write. This PR switches to using GetMasterX()

Fix an issue where the `RefreshPostStats` job could fail

@devinbinnie devinbinnie added the 2: Dev Review Requires review by a developer label May 9, 2024
@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 9, 2024
@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels May 13, 2024
@devinbinnie devinbinnie merged commit 3fdf4fc into master May 13, 2024
41 checks passed
@devinbinnie devinbinnie deleted the fix_poststats_job branch May 13, 2024 12:55
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmhealey hmhealey hmhealey approved these changes

@nickmisasi nickmisasi nickmisasi approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@devinbinnie @hmhealey @nickmisasi @amyblais @mm-cloud-bot